Source/core/accessibility/AccessibilityNodeObject.cpp - Issue 22331005: Clean up accessibility enums for use in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AccessibilityNodeObject.cpp

Issue 22331005: Clean up accessibility enums for use in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update failing tests, add one missing role Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AccessibilityNodeObject.cpp

diff --git a/Source/core/accessibility/AccessibilityNodeObject.cpp b/Source/core/accessibility/AccessibilityNodeObject.cpp

index 5f30849ab580092b3cd95271b87cf89ca6b8b2f0..23615168130f8cddb0ee8869b9dbc4a7a4f67a2b 100644

--- a/Source/core/accessibility/AccessibilityNodeObject.cpp

+++ b/Source/core/accessibility/AccessibilityNodeObject.cpp

@@ -175,7 +175,7 @@ AccessibilityRole AccessibilityNodeObject::determineAccessibilityRole()

return ariaRole;

if (node()->isLink())

- return WebCoreLinkRole;

+ return LinkRole;

if (node()->isTextNode())

return StaticTextRole;

if (node()->hasTagName(buttonTag))

@@ -524,7 +524,7 @@ bool AccessibilityNodeObject::isInputImage() const

bool AccessibilityNodeObject::isLink() const

{

- return roleValue() == WebCoreLinkRole;

+ return roleValue() == LinkRole;

}

bool AccessibilityNodeObject::isMenu() const