Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2233083002: Compute both strong and spec mode unlinked bundles. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute both strong and spec mode unlinked bundles. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e1fa540dc5783bb098240f7140335d8d3cb4bafc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Link in strong or spec mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -27 lines) Patch
M pkg/analyzer/lib/src/summary/pub_summary.dart View 1 13 chunks +43 lines, -23 lines 0 comments Download
M pkg/analyzer/test/src/summary/pub_summary_test.dart View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 4 months ago (2016-08-10 19:30:28 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2233083002/diff/1/pkg/analyzer/lib/src/summary/pub_summary.dart File pkg/analyzer/lib/src/summary/pub_summary.dart (right): https://codereview.chromium.org/2233083002/diff/1/pkg/analyzer/lib/src/summary/pub_summary.dart#newcode458 pkg/analyzer/lib/src/summary/pub_summary.dart:458: }, false); Need to pass true when linking ...
4 years, 4 months ago (2016-08-10 21:34:42 UTC) #2
scheglov
https://codereview.chromium.org/2233083002/diff/1/pkg/analyzer/lib/src/summary/pub_summary.dart File pkg/analyzer/lib/src/summary/pub_summary.dart (right): https://codereview.chromium.org/2233083002/diff/1/pkg/analyzer/lib/src/summary/pub_summary.dart#newcode458 pkg/analyzer/lib/src/summary/pub_summary.dart:458: }, false); On 2016/08/10 21:34:42, Paul Berry wrote: > ...
4 years, 4 months ago (2016-08-10 21:41:37 UTC) #3
scheglov
4 years, 4 months ago (2016-08-10 21:42:03 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e1fa540dc5783bb098240f7140335d8d3cb4bafc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698