Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2233073002: Add more error printing to know why command buffer lib failed to load. (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add more error printing to know why command buffer lib failed to load. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233073002 Committed: https://skia.googlesource.com/skia/+/80e38ac117371129df2eb27fe674c7ca84256971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/ports/SkOSLibrary_posix.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
4 years, 4 months ago (2016-08-10 18:49:11 UTC) #3
robertphillips
lgtm
4 years, 4 months ago (2016-08-10 18:56:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233073002/1
4 years, 4 months ago (2016-08-10 19:01:21 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 19:26:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/80e38ac117371129df2eb27fe674c7ca84256971

Powered by Google App Engine
This is Rietveld 408576698