Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2233053002:
Reorganize test expectations to consolidate paint team tests (Closed)
|
Created:
4 years, 4 months ago by Stephen Chennney Modified:
4 years, 4 months ago CC:
blink-reviews, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReorganize test expectations to consolidate paint team tests
The aim is to consolidate tests owned by the paint team to make future change tracking easier. It is a goal of the team to track layout team regressions, additions and fixes.
This patch should have no net effect on test expectations. It is a line permutation only.
R=chrishtr@chromium.org
BUG=636475
Committed: https://crrev.com/e01bd4dbaa7ea4468e69dfa2447234cf0cecb223
Cr-Commit-Position: refs/heads/master@{#411123}
Patch Set 1 : Re-add test lost during rebase #Patch Set 2 : Re-add expectation change lost during rebase #
Total comments: 1
Messages
Total messages: 16 (9 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by schenney@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I'd like to arrange TestExpectations to make it easier to track added/removed paint team tests. Here I've batched them all together with SPV2 in one block then the rest in another block. The aim is to diff future versions of TestExpectations and easily see if any of the tests in the block have been removed or changed, and then look at newly added tests anywhere in expectations for our directories and move them into the block when triaged. This change should consist only of moved lines. I've checked for obvious problems but I'll still have to be careful when it lands in case I screwed up somehow or missed changes in-flight.
Description was changed from ========== Reorganize test expectations to consolidate paint team tests R=chrishtr@chromium.org BUG=636475 ========== to ========== Reorganize test expectations to consolidate paint team tests The aim is to consolidate tests owned by the paint team to make future change tracking easier. It is a goal of the team to track layout team regressions, additions and fixes. This patch should have no net effect on test expectations. It is a line permutation only. R=chrishtr@chromium.org BUG=636475 ==========
chrishtr@chromium.org changed reviewers: + pdr@chromium.org
+pdr for SPv2 layout test review. Oherwise looks good.
https://codereview.chromium.org/2233053002/diff/40001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2233053002/diff/40001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/TestExpectations:32: # as we go. Please remove [ Pass ] lines instead of rebaselining these tests. I'm actually planning on removing most of these and just leaving 5-10 to run on the CQ so people don't totally break us. The [ PASS ] approach is just too confusing to everyone else on the blink team. I'll do this later today, or you can if you want. LGTM for this patch as it's a very nice cleanup regardless.
On 2016/08/10 19:31:32, pdr. wrote: > https://codereview.chromium.org/2233053002/diff/40001/third_party/WebKit/Layo... > File third_party/WebKit/LayoutTests/TestExpectations (right): > > https://codereview.chromium.org/2233053002/diff/40001/third_party/WebKit/Layo... > third_party/WebKit/LayoutTests/TestExpectations:32: # as we go. Please remove [ > Pass ] lines instead of rebaselining these tests. > I'm actually planning on removing most of these and just leaving 5-10 to run on > the CQ so people don't totally break us. The [ PASS ] approach is just too > confusing to everyone else on the blink team. I'll do this later today, or you > can if you want. LGTM for this patch as it's a very nice cleanup regardless. I'll land this first and leave it to you to clean up SPV2 as you see fit. I'm not planning to include SPV2 in tracking numbers because I understand that you are tracking them separately.
The CQ bit was unchecked by schenney@chromium.org
The CQ bit was checked by schenney@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reorganize test expectations to consolidate paint team tests The aim is to consolidate tests owned by the paint team to make future change tracking easier. It is a goal of the team to track layout team regressions, additions and fixes. This patch should have no net effect on test expectations. It is a line permutation only. R=chrishtr@chromium.org BUG=636475 ========== to ========== Reorganize test expectations to consolidate paint team tests The aim is to consolidate tests owned by the paint team to make future change tracking easier. It is a goal of the team to track layout team regressions, additions and fixes. This patch should have no net effect on test expectations. It is a line permutation only. R=chrishtr@chromium.org BUG=636475 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Reorganize test expectations to consolidate paint team tests The aim is to consolidate tests owned by the paint team to make future change tracking easier. It is a goal of the team to track layout team regressions, additions and fixes. This patch should have no net effect on test expectations. It is a line permutation only. R=chrishtr@chromium.org BUG=636475 ========== to ========== Reorganize test expectations to consolidate paint team tests The aim is to consolidate tests owned by the paint team to make future change tracking easier. It is a goal of the team to track layout team regressions, additions and fixes. This patch should have no net effect on test expectations. It is a line permutation only. R=chrishtr@chromium.org BUG=636475 Committed: https://crrev.com/e01bd4dbaa7ea4468e69dfa2447234cf0cecb223 Cr-Commit-Position: refs/heads/master@{#411123} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e01bd4dbaa7ea4468e69dfa2447234cf0cecb223 Cr-Commit-Position: refs/heads/master@{#411123} |
