blimp/client/core/contents/blimp_contents_impl.cc - Issue 2233023002: Adding BlimpNavigationController to Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_contents_impl.cc

Issue 2233023002: Adding BlimpNavigationController to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nav_handler_remove

Patch Set: @nyquist feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/contents/blimp_contents_impl.h ('k') | blimp/client/core/contents/blimp_navigation_controller_impl.h » ('j') | blimp/client/core/contents/blimp_navigation_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/blimp_contents_impl.cc

diff --git a/blimp/client/core/contents/blimp_contents_impl.cc b/blimp/client/core/contents/blimp_contents_impl.cc

index bfbbca356113bdd5f4e70743840be803cef4daf0..0b2de41629f5642500912f9a642c3ff2f71f1f8c 100644

--- a/blimp/client/core/contents/blimp_contents_impl.cc

+++ b/blimp/client/core/contents/blimp_contents_impl.cc

@@ -31,8 +31,7 @@ BlimpContentsImpl::~BlimpContentsImpl() {

#if defined(OS_ANDROID)

-base::android::ScopedJavaLocalRef<jobject>

-BlimpContentsImpl::GetJavaBlimpContentsImpl() {

+base::android::ScopedJavaLocalRef<jobject> BlimpContentsImpl::GetJavaObject() {

return GetBlimpContentsImplAndroid()->GetJavaObject();

}