blimp/client/public/contents/blimp_contents.h - Issue 2233023002: Adding BlimpNavigationController to Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/public/contents/blimp_contents.h

Issue 2233023002: Adding BlimpNavigationController to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nav_handler_remove

Patch Set: initial comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/android/blimp_client_context_impl_android.cc ('K') | « blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpNavigationController.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/public/contents/blimp_contents.h

diff --git a/blimp/client/public/contents/blimp_contents.h b/blimp/client/public/contents/blimp_contents.h

index ea11aa7305a00239917de041d3f01b50c2fd34d8..109d321205c7a988a89b9e6eb401bfe3ae504214 100644

--- a/blimp/client/public/contents/blimp_contents.h

+++ b/blimp/client/public/contents/blimp_contents.h

@@ -9,6 +9,10 @@

#include "base/supports_user_data.h"

#include "url/gurl.h"

+#if defined(OS_ANDROID)

+#include "base/android/scoped_java_ref.h"

+#endif

namespace blimp {

namespace client {

@@ -31,6 +35,10 @@ class BlimpContents : public base::SupportsUserData {

virtual void AddObserver(BlimpContentsObserver* observer) = 0;

virtual void RemoveObserver(BlimpContentsObserver* observer) = 0;

+#if defined(OS_ANDROID)

+ virtual base::android::ScopedJavaLocalRef<jobject> GetJavaObject() = 0;

nyquist 2016/08/16 19:09:20 Could you add a comment as to what is the guarante

shaktisahu 2016/08/16 23:46:13 Done.

+#endif

protected:

BlimpContents() {}