blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc - Issue 2233023002: Adding BlimpNavigationController to Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc

Issue 2233023002: Adding BlimpNavigationController to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nav_handler_remove

Patch Set: initial comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/android/blimp_client_context_impl_android.cc ('K') | « blimp/client/core/contents/android/blimp_navigation_controller_impl_android.h ('k') | blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java » ('j') | blimp/client/public/contents/blimp_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc

diff --git a/blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc b/blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc

index f8abded0540802d405589c6661a2c53508687661..37c8e58a0f3a31d8010129e6c81034433988cbd2 100644

--- a/blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc

+++ b/blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc

@@ -63,6 +63,12 @@ BlimpNavigationControllerImplAndroid::GetURL(JNIEnv* env, jobject jobj) {

return base::android::ConvertUTF8ToJavaString(env, url.spec());

}

+base::android::ScopedJavaLocalRef<jstring>

+BlimpNavigationControllerImplAndroid::GetTitle(JNIEnv* env, jobject jobj) {

+ std::string title = blimp_navigation_controller_impl_->GetTitle();

+ return base::android::ConvertUTF8ToJavaString(env, title);

jboolean BlimpNavigationControllerImplAndroid::CanGoBack(

JNIEnv* env,

const JavaParamRef<jobject>& obj) {