blimp/client/core/contents/android/blimp_contents_factory.cc - Issue 2233023002: Adding BlimpNavigationController to Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/android/blimp_contents_factory.cc

Issue 2233023002: Adding BlimpNavigationController to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nav_handler_remove

Patch Set: initial comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/android/blimp_client_context_impl_android.cc ('K') | « blimp/client/core/android/blimp_client_context_impl_android.cc ('k') | blimp/client/core/contents/android/blimp_navigation_controller_impl_android.h » ('j') | blimp/client/public/contents/blimp_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/android/blimp_contents_factory.cc

diff --git a/blimp/client/core/contents/android/blimp_contents_factory.cc b/blimp/client/core/contents/android/blimp_contents_factory.cc

index ae3df18b7b310c89c5232d1bd9f9efbbb8c73e19..e85d7af7b0d1f31ff572353ecefff67414248d58 100644

--- a/blimp/client/core/contents/android/blimp_contents_factory.cc

+++ b/blimp/client/core/contents/android/blimp_contents_factory.cc

@@ -25,7 +25,7 @@ static base::android::ScopedJavaLocalRef<jobject> CreateBlimpContents(

// To delete |blimp_contents_impl|, the Java caller must call the

// destroy() method on BlimpContents.

BlimpContentsImpl* blimp_contents_impl = new BlimpContentsImpl(kDummyTabId);

- return blimp_contents_impl->GetJavaBlimpContentsImpl();

+ return blimp_contents_impl->GetJavaObject();

}

bool RegisterBlimpContentsFactoryJni(JNIEnv* env) {