blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java - Issue 2233023002: Adding BlimpNavigationController to Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java

Issue 2233023002: Adding BlimpNavigationController to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nav_handler_remove

Patch Set: Fixing unit tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc ('k') | blimp/client/core/contents/blimp_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java

diff --git a/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java b/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java

index fcee60baa782993328dfc4f26385e82148eef4ef..f5850b3ba34f5682c8f6271ffeecfd38b5d6517d 100644

--- a/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java

+++ b/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java

@@ -50,6 +50,12 @@ public class BlimpNavigationControllerImpl implements BlimpNavigationController

}

@Override

+ public String getTitle() {

+ if (mNativeBlimpNavigationControllerImplAndroid == 0) return "";

+ return nativeGetTitle(mNativeBlimpNavigationControllerImplAndroid);

+ }

+ @Override

public boolean canGoBack() {

if (mNativeBlimpNavigationControllerImplAndroid == 0) return false;

return nativeCanGoBack(mNativeBlimpNavigationControllerImplAndroid);

@@ -74,7 +80,7 @@ public class BlimpNavigationControllerImpl implements BlimpNavigationController

}

@Override

- public void reload(boolean checkForRepost) {

+ public void reload() {

if (mNativeBlimpNavigationControllerImplAndroid == 0) return;

nativeReload(mNativeBlimpNavigationControllerImplAndroid);

}

@@ -86,4 +92,5 @@ public class BlimpNavigationControllerImpl implements BlimpNavigationController

private native boolean nativeCanGoForward(long nativeBlimpNavigationControllerImplAndroid);

private native void nativeLoadURL(long nativeBlimpNavigationControllerImplAndroid, String url);

private native String nativeGetURL(long nativeBlimpNavigationControllerImplAndroid);

+ private native String nativeGetTitle(long nativeBlimpNavigationControllerImplAndroid);

}