blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java - Issue 2233023002: Adding BlimpNavigationController to Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

Issue 2233023002: Adding BlimpNavigationController to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nav_handler_remove

Patch Set: Fixing unit tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java ('k') | blimp/client/core/contents/android/blimp_navigation_controller_impl_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

diff --git a/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java b/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

index 3fe561b884ac56a6ce00b10d28557b9f837ad04a..368058d4adcb418eaeeb8ec2fe4c313d4f9daf35 100644

--- a/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

+++ b/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

@@ -54,11 +54,15 @@ public class DummyBlimpClientContext implements BlimpClientContext {

}

@Override

- public void attachBlimpPreferences(PreferenceFragment fragment,

- BlimpSettingsCallbacks callbacks) {

+ public boolean isBlimpEnabled() {

+ return false;

}

@Override

+ public void attachBlimpPreferences(

+ PreferenceFragment fragment, BlimpSettingsCallbacks callbacks) {}

+ @Override

public void setDelegate(BlimpClientContextDelegate delegate) {

}