blimp/client/core/contents/blimp_navigation_controller_impl.h - Issue 2233023002: Adding BlimpNavigationController to Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_navigation_controller_impl.h

Issue 2233023002: Adding BlimpNavigationController to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nav_handler_remove

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/contents/blimp_contents_impl.cc ('k') | blimp/client/core/contents/blimp_navigation_controller_impl.cc » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/blimp_navigation_controller_impl.h

diff --git a/blimp/client/core/contents/blimp_navigation_controller_impl.h b/blimp/client/core/contents/blimp_navigation_controller_impl.h

index 1193fbaf9da96a848fce26f6c4746cc4f75b3354..cb31f6adbb14eab186ff735247218f2ad7404adf 100644

--- a/blimp/client/core/contents/blimp_navigation_controller_impl.h

+++ b/blimp/client/core/contents/blimp_navigation_controller_impl.h

@@ -38,6 +38,7 @@ class BlimpNavigationControllerImpl

void GoBack() override;

void GoForward() override;

const GURL& GetURL() override;

+ const std::string& GetTitle();

private:

// NavigationFeatureDelegate implementation.

@@ -58,6 +59,7 @@ class BlimpNavigationControllerImpl

// The currently active URL.

GURL current_url_;

+ std::string current_title_;

David Trainor- moved to gerrit 2016/08/11 21:40:19 Maybe comment?

shaktisahu 2016/08/12 22:11:48 Done.

DISALLOW_COPY_AND_ASSIGN(BlimpNavigationControllerImpl);

};