Adding BlimpNavigationController to Tab

blimp/client/core/contents/blimp_navigation_controller_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/core/contents/blimp_navigation_controller_impl.h"
 
 #include "blimp/client/core/contents/blimp_navigation_controller_delegate.h"
 
 namespace {
 // TODO(shaktisahu): NavigationFeature currently needs a tab_id. Remove this
@@ skipping 24 matching lines @@
   current_url_ = url;
   navigation_feature_->NavigateToUrlText(kDummyTabId, current_url_.spec());
 }
 
 void BlimpNavigationControllerImpl::Reload() {
   navigation_feature_->Reload(kDummyTabId);
 }
 
 bool BlimpNavigationControllerImpl::CanGoBack() const {
   NOTIMPLEMENTED();
-  return false;
+  return true;
 }
 
 bool BlimpNavigationControllerImpl::CanGoForward() const {
   NOTIMPLEMENTED();
-  return false;
+  return true;
 }
 
 void BlimpNavigationControllerImpl::GoBack() {
   navigation_feature_->GoBack(kDummyTabId);
 }
 
 void BlimpNavigationControllerImpl::GoForward() {
   navigation_feature_->GoForward(kDummyTabId);
 }
 
 const GURL& BlimpNavigationControllerImpl::GetURL() {
   return current_url_;
 }
 
+const std::string& BlimpNavigationControllerImpl::GetTitle() {
+  return current_title_;
+}
+
 void BlimpNavigationControllerImpl::OnUrlChanged(int tab_id, const GURL& url) {
+  current_url_ = url;

[David Trainor- moved to gerrit, 2016/08/18 17:06:30]

Do we have unit tests for this?  It looks like it would have failed earlier.

[shaktisahu, 2016/08/18 19:36:06]

Actually this is also set in LoadURL() due to which it didn't fail. Updated the
test.

   delegate_->OnNavigationStateChanged();
 }
 
 void BlimpNavigationControllerImpl::OnFaviconChanged(int tab_id,
                                                      const SkBitmap& favicon) {
   delegate_->OnNavigationStateChanged();
 }
 
 void BlimpNavigationControllerImpl::OnTitleChanged(int tab_id,
                                                    const std::string& title) {
+  current_title_ = title;
   delegate_->OnNavigationStateChanged();
 }
 
 void BlimpNavigationControllerImpl::OnLoadingChanged(int tab_id, bool loading) {
   delegate_->OnNavigationStateChanged();
 }
 
 void BlimpNavigationControllerImpl::OnPageLoadStatusUpdate(int tab_id,
                                                            bool completed) {
   delegate_->OnNavigationStateChanged();
 }
 
 }  // namespace client
 }  // namespace blimp