Adding BlimpNavigationController to Tab

blimp/client/core/android/blimp_client_context_impl_android.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/core/android/blimp_client_context_impl_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
 #include "blimp/client/core/contents/blimp_contents_impl.h"
@@ skipping 43 matching lines @@
   Java_BlimpClientContextImpl_clearNativePtr(
       base::android::AttachCurrentThread(), java_obj_.obj());
 }
 
 base::android::ScopedJavaLocalRef<jobject>
 BlimpClientContextImplAndroid::GetJavaObject() {
   return base::android::ScopedJavaLocalRef<jobject>(java_obj_);
 }
 
 base::android::ScopedJavaLocalRef<jobject>
 BlimpClientContextImplAndroid::CreateBlimpContentsJava(JNIEnv* env,

[nyquist, 2016/08/16 19:09:20]

Do we still need this, or could we remove all of this from the public interface,
etc?

I guess that would be fine to do in a follow-up as well. But I believe that we
were literally waiting for this exact patch (where we construct BlimpContents in
//chrome), to see if we still needed it.

[shaktisahu, 2016/08/16 23:46:13]

I think we might need to construct BlimpContents a few other places (e.g. tab
restore). May be we should keep it for now.

                                                        jobject jobj) {
   std::unique_ptr<BlimpContents> blimp_contents =
       BlimpClientContextImpl::CreateBlimpContents();
   // This intentionally releases the ownership and gives it to Java.
   BlimpContentsImpl* blimp_contents_impl =
       static_cast<BlimpContentsImpl*>(blimp_contents.release());
-  return blimp_contents_impl->GetJavaBlimpContentsImpl();
+  return blimp_contents_impl->GetJavaObject();
 }
 
 GURL BlimpClientContextImplAndroid::GetAssignerURL() {
   JNIEnv* env = base::android::AttachCurrentThread();
   base::android::ScopedJavaLocalRef<jstring> jurl =
       Java_BlimpClientContextImpl_getAssignerUrl(env, java_obj_.obj());
   GURL assigner_url = GURL(ConvertJavaStringToUTF8(env, jurl));
   DCHECK(assigner_url.is_valid());
   return assigner_url;
 }
 
 }  // namespace client
 }  // namespace blimp