Adding BlimpNavigationController to Tab

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 433 matching lines @@
     /**
      * @return Whether contextual search is allowed for this activity or not.
      */
     protected boolean isContextualSearchAllowed() {
         return true;
     }
 
     @Override
     public void initializeState() {
         super.initializeState();
+        mBlimpClientContextDelegate =

[David Trainor- moved to gerrit, 2016/08/11 21:40:19]

What's the rationale to moving this earlier?  So it's available when the tab
model is created?

Have you talked to Alex?  I thought he was moving this setup later (or maybe
it's just the connect() call).

[xingliu, 2016/08/11 23:26:25]

I think this is fine, the connect call is in a callback of
AccountTrackerService.onSystemAccountsSeedingComplete() in the token branch. 

[nyquist, 2016/08/12 05:57:18]

Also, I think this makes sense here. From BrowserParts in //content:

    /**
     * Called during {@link
ChromeBrowserInitializer#handlePostNativeStartup(BrowserParts)}.
     * Initialize the tab state restoring tabs or creating new tabs.
     */
    void initializeState();

And we will need to know whether we have blimp or not during tab restore going
forward I believe.

And yeah, connect() can definitely happen later. That feels all right to me at
least. We just need to setup the initial parts.

[shaktisahu, 2016/08/12 22:11:49]

Yes, I moved this as early as possible since the very first tab is getting
initialized before native initialization could complete.

+                ChromeBlimpClientContextDelegate.createAndSetDelegateForContext(
+                        Profile.getLastUsedProfile().getOriginalProfile());
+
         IntentHandler.setTestIntentsEnabled(
                 CommandLine.getInstance().hasSwitch(ContentSwitches.ENABLE_TEST_INTENTS));
         mIntentHandler = new IntentHandler(createIntentHandlerDelegate(), getPackageName());
     }
 
     @Override
     public void initializeCompositor() {
         TraceEvent.begin("ChromeActivity:CompositorInitialization");
         super.initializeCompositor();
 
@@ skipping 474 matching lines @@
         if (Build.VERSION.CODENAME.equals("N") || Build.VERSION.SDK_INT > Build.VERSION_CODES.M) {
             getWindow().setBackgroundDrawable(new ColorDrawable(
                     ApiCompatibilityUtils.getColor(getResources(),
                             R.color.resizing_background_color)));
         } else {
             removeWindowBackground();
         }
         DownloadManagerService.getDownloadManagerService(
                 getApplicationContext()).onActivityLaunched();
 
-        mBlimpClientContextDelegate = ChromeBlimpClientContextDelegate
-                .createAndSetDelegateForContext(Profile.getLastUsedProfile().getOriginalProfile());
-
         super.finishNativeInitialization();
     }
 
     /**
      * Called when the accessibility status of this device changes.  This might be triggered by
      * touch exploration or general accessibility status updates.  It is an aggregate of two other
      * accessibility update methods.
      * @see #onAccessibilityModeChanged(boolean)
      * @see #onTouchExplorationStateChanged(boolean)
      * @param enabled Whether or not accessibility and touch exploration are currently enabled.
@@ skipping 804 matching lines @@
                 "Android.MultiWindowMode.IsTabletScreenWidthBelow600",
                 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP);
 
         if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) {
             RecordHistogram.recordLinearCountHistogram(
                     "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1,
                     DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50);
         }
     }
 }