Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2232983002:
Add TBR to commit message (Closed)
|
Created:
4 years, 4 months ago by dcampb Modified:
4 years, 4 months ago CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd TBR to commit message
BUG=636379
Committed: https://crrev.com/f08a90bd55aac0e2bc25fb75d7e7d9974bb79ee2
Cr-Commit-Position: refs/heads/master@{#411133}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add TBR to generate_upload_command #
Total comments: 3
Patch Set 3 : added new lines #Messages
Total messages: 15 (6 generated)
Description was changed from ========== modified Merge branch 'master' of https://chromium.googlesource.com/chromium/src fixed Merge branch 'master' of https://chromium.googlesource.com/chromium/src Merge branch 'master' of https://chromium.googlesource.com/chromium/src m BUG= ========== to ========== Add TBR to commit message BUG=636379 ==========
dcampb@google.com changed reviewers: + dpranke@chromium.org, qyearsley@chromium.org, raikiri@google.com
lgtm
https://codereview.chromium.org/2232983002/diff/1/third_party/WebKit/Tools/Sc... File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): https://codereview.chromium.org/2232983002/diff/1/third_party/WebKit/Tools/Sc... third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:347: TBR=qyearsley@chromium.org, dpranke@chromium.org """ I would prefer not to get these. I think that you can do "TBR=\n" and leave it blank, and I suspect that's what the auto-rebaseline-bot does, but you should check and be consistent.
On 2016/08/10 at 16:52:10, dpranke wrote: > https://codereview.chromium.org/2232983002/diff/1/third_party/WebKit/Tools/Sc... > File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): > > https://codereview.chromium.org/2232983002/diff/1/third_party/WebKit/Tools/Sc... > third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:347: TBR=qyearsley@chromium.org, dpranke@chromium.org """ > I would prefer not to get these. I think that you can do "TBR=\n" and leave it blank, and I suspect that's what the auto-rebaseline-bot does, but you should check and be consistent. Looks like the auto-rebaseline bot adds the owner of the patch that added the NeedsRebaseline commands in the TBR line. For the w3c-test-roller bot, I think that probably the owners of the test directories that are being updated could be added. (As-is, those people are added to the CC list). Note, as discussed offline, we want there to always be a TBR line even if all of the try jobs pass on the first go (i.e. tests are modified and there are no new failures), so we probably want the TBR line to be added in the message given to `git cl upload -m` in generate_upload_command.
Patchset #2 (id:20001) has been deleted
LGTM with nits https://codereview.chromium.org/2232983002/diff/40001/third_party/WebKit/Tool... File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (left): https://codereview.chromium.org/2232983002/diff/40001/third_party/WebKit/Tool... third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:345: message = '\'Modifies TestExpectations and/or downloads new baselines for tests .\'' Nit: This change could be un-done for this CL. https://codereview.chromium.org/2232983002/diff/40001/third_party/WebKit/Tool... third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:349: Nit: This newline should be kept. https://codereview.chromium.org/2232983002/diff/40001/third_party/WebKit/Tool... File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): https://codereview.chromium.org/2232983002/diff/40001/third_party/WebKit/Tool... third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:364: TBR=qyearsley@chromium.org""" Could add another newline after this, i.e. message = """W3C auto test importer TBR=qyearsley@chromium.org """
The CQ bit was checked by dcampb@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from raikiri@google.com, qyearsley@chromium.org Link to the patchset: https://codereview.chromium.org/2232983002/#ps60001 (title: "added new lines")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add TBR to commit message BUG=636379 ========== to ========== Add TBR to commit message BUG=636379 Committed: https://crrev.com/f08a90bd55aac0e2bc25fb75d7e7d9974bb79ee2 Cr-Commit-Position: refs/heads/master@{#411133} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f08a90bd55aac0e2bc25fb75d7e7d9974bb79ee2 Cr-Commit-Position: refs/heads/master@{#411133} |
