Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2232963002: Remove no longer existing friend. (Closed)

Created:
4 years, 4 months ago by bungeman-skia
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove no longer existing friend. sk_fontmgr_create_default used to exist before SkFontMgr::RefDefault could do the job better. There are no actual implementations for this function, so SkFontMgr should no longer be friends with it. TBR=reed Removes a deceased friend. Committed: https://skia.googlesource.com/skia/+/ce81ed58e2fd6bfa9043a8b5ab94191f52683628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M include/ports/SkFontMgr.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
bungeman-skia
mtklein: looks like you removed the last implementation of this function at https://codereview.chromium.org/1322933005/diff/110001/src/core/SkFontMgr.cpp .
4 years, 4 months ago (2016-08-10 16:02:05 UTC) #6
mtklein
lgtm
4 years, 4 months ago (2016-08-10 16:07:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232963002/1
4 years, 4 months ago (2016-08-10 16:08:46 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 16:23:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ce81ed58e2fd6bfa9043a8b5ab94191f52683628

Powered by Google App Engine
This is Rietveld 408576698