Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 22329008: Update manifest to hide the connectivity diagnostics from the launcher (Closed)

Created:
7 years, 4 months ago by Zachary Kuznia
Modified:
7 years, 4 months ago
Reviewers:
Dmitry Polukhin, zel
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Update manifest to hide the connectivity diagnostics from the launcher BUG=254738 R=dpolukhin@chromium.org, zelidrag@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216783

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Zachary Kuznia
Please take a look
7 years, 4 months ago (2013-08-09 18:40:05 UTC) #1
Dmitry Polukhin
lgtm
7 years, 4 months ago (2013-08-09 18:45:10 UTC) #2
Zachary Kuznia
Hi zelidrag, Could you do an OWNERS review of this? Thanks, -Zach
7 years, 4 months ago (2013-08-09 18:52:53 UTC) #3
zel
lgtm
7 years, 4 months ago (2013-08-09 18:54:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/22329008/1
7 years, 4 months ago (2013-08-09 18:58:28 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-09 22:46:23 UTC) #6
Zachary Kuznia
7 years, 4 months ago (2013-08-09 23:54:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r216783 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698