Unpremultiply SkBitmaps for PDF output

src/pdf/SkPDFImage.cpp

Index: src/pdf/SkPDFImage.cpp
diff --git a/src/pdf/SkPDFImage.cpp b/src/pdf/SkPDFImage.cpp
index a5cb4c20d1b9e187948cc6654d590b219df4d686..6de17a27c8fd351ac9af0c10c7d3e10aa729e146 100644
--- a/src/pdf/SkPDFImage.cpp
+++ b/src/pdf/SkPDFImage.cpp
@@ -18,6 +18,51 @@
 
 namespace {
 
+static void unpremultiply_and_pack_argb8888(uint8_t alpha, uint32_t src,
+                                            uint8_t* dst) {
+    if (alpha != SK_AlphaOPAQUE) {
+        SkColor unpremul = SkUnPreMultiply::PMColorToColor(src);
+        dst[0] = SkColorGetR(unpremul);
+        dst[1] = SkColorGetG(unpremul);
+        dst[2] = SkColorGetB(unpremul);
+    } else {
+        dst[0] = SkGetPackedR32(src);
+        dst[1] = SkGetPackedG32(src);
+        dst[2] = SkGetPackedB32(src);
+    }
+}
+
+static void unpremultiply_and_pack_argb4444(uint8_t alpha0, uint8_t alpha1,

[vandebo (ex-Chrome), 2013/08/12 22:20:48]

Don't pass in alpha, just extract it from source again.

[ducky, 2013/08/12 23:25:23]

Done.

+                                            uint16_t src0, uint16_t src1,
+                                            uint8_t* dst) {

[vandebo (ex-Chrome), 2013/08/12 22:20:48]

uint8_t dst[3]

[ducky, 2013/08/12 23:25:23]

Done.

+    if (alpha0 != 0x0F) {

[vandebo (ex-Chrome), 2013/08/12 22:20:48]

SK_AlphaOPAQUE

[ducky, 2013/08/12 23:25:23]

Done.

+        alpha0 = alpha0 | (alpha0 << 4);
+        SkUnPreMultiply::Scale scale0 = SkUnPreMultiply::GetScale(alpha0);
+        dst[0] = SkUnPreMultiply::ApplyScale(scale0, SkGetPackedR4444(src0));
+        dst[0] = dst[0] << 4;

[vandebo (ex-Chrome), 2013/08/12 22:20:48]

Breaking out the shift into a different assignment makes the code harder to
understand.  Do the shift in the previous line.

[ducky, 2013/08/12 23:25:23]

Fixed.

+        dst[0] |= SkUnPreMultiply::ApplyScale(scale0, SkGetPackedG4444(src0));
+        dst[1] = SkUnPreMultiply::ApplyScale(scale0, SkGetPackedB4444(src0));
+        dst[1] = dst[1] << 4;
+    } else {
+        dst[0] = SkGetPackedR4444(src0) << 4;
+        dst[0] |= SkGetPackedG4444(src0);
+        dst[1] = SkGetPackedB4444(src0) << 4;
+    }
+
+    if (alpha1 != 0x0F) {
+        alpha1 = alpha1 | (alpha1 << 4);
+        SkUnPreMultiply::Scale scale1 = SkUnPreMultiply::GetScale(alpha1);
+        dst[1] |= SkUnPreMultiply::ApplyScale(scale1, SkGetPackedR4444(src1));
+        dst[2] = SkUnPreMultiply::ApplyScale(scale1, SkGetPackedG4444(src1));
+        dst[2] = dst[2] << 4;
+        dst[2] |= SkUnPreMultiply::ApplyScale(scale1, SkGetPackedB4444(src1));
+    } else {
+        dst[1] |= SkGetPackedR4444(src1);
+        dst[2] = SkGetPackedG4444(src1) << 4;
+        dst[2] |= SkGetPackedB4444(src1);
+    }
+}
+
 void extractImageData(const SkBitmap& bitmap, const SkIRect& srcRect,
                       SkStream** imageData, SkStream** alphaData) {
     SkMemoryStream* image = NULL;
@@ -49,36 +94,43 @@ void extractImageData(const SkBitmap& bitmap, const SkIRect& srcRect,
                 uint16_t* src = bitmap.getAddr16(0, y);
                 int x;
                 for (x = srcRect.fLeft; x + 1 < srcRect.fRight; x += 2) {
-                    dst[0] = (SkGetPackedR4444(src[x]) << 4) |
-                        SkGetPackedG4444(src[x]);
-                    dst[1] = (SkGetPackedB4444(src[x]) << 4) |
-                        SkGetPackedR4444(src[x + 1]);
-                    dst[2] = (SkGetPackedG4444(src[x + 1]) << 4) |
-                        SkGetPackedB4444(src[x + 1]);
-                    dst += 3;
-                    alphaDst[0] = (SkGetPackedA4444(src[x]) << 4) |
-                        SkGetPackedA4444(src[x + 1]);
-                    if (alphaDst[0] != 0xFF) {
+                    uint16_t pixel0 = src[x];

[vandebo (ex-Chrome), 2013/08/12 22:20:48]

Inline these four variables.

+                    uint16_t pixel1 = src[x + 1];
+                    uint8_t alpha0 = SkGetPackedA4444(pixel0);
+                    uint8_t alpha1 = SkGetPackedA4444(pixel1);
+                    alphaDst[0] = (alpha0 << 4) | alpha1;
+                    if (alphaDst[0] != SK_AlphaOPAQUE) {
                         hasAlpha = true;
                     }
                     if (alphaDst[0]) {
                         isTransparent = false;
                     }
+                    unpremultiply_and_pack_argb4444(alpha0, alpha1,
+                                                    pixel0, pixel1,
+                                                    dst);
                     alphaDst++;
+                    dst += 3;
                 }
                 if (srcRect.width() & 1) {
-                    dst[0] = (SkGetPackedR4444(src[x]) << 4) |
-                        SkGetPackedG4444(src[x]);
-                    dst[1] = (SkGetPackedB4444(src[x]) << 4);
-                    dst += 2;
-                    alphaDst[0] = (SkGetPackedA4444(src[x]) << 4);
+                    uint16_t pixel = src[x];
+                    uint8_t alpha = SkGetPackedA4444(pixel);
+                    alphaDst[0] = (alpha << 4);
+                    // Use a buffer to translate from the usual 2 4444 values
+                    // in 12 bytes to the single 4444 value in 2 bytes.
+                    uint8_t buffer[3];
                     if (alphaDst[0] != 0xF0) {
                         hasAlpha = true;
                     }
                     if (alphaDst[0] & 0xF0) {
                         isTransparent = false;
                     }
+                    unpremultiply_and_pack_argb4444(alpha, 0x0F, pixel, 0x00,
+                                                    buffer);
+                    dst[0] = buffer[0];
+                    dst[1] = buffer[1];
+
                     alphaDst++;
+                    dst += 2;
                 }
             }
             break;
@@ -108,18 +160,17 @@ void extractImageData(const SkBitmap& bitmap, const SkIRect& srcRect,
             for (int y = srcRect.fTop; y < srcRect.fBottom; y++) {
                 uint32_t* src = bitmap.getAddr32(0, y);
                 for (int x = srcRect.fLeft; x < srcRect.fRight; x++) {
-                    dst[0] = SkGetPackedR32(src[x]);
-                    dst[1] = SkGetPackedG32(src[x]);
-                    dst[2] = SkGetPackedB32(src[x]);
-                    dst += 3;
-                    alphaDst[0] = SkGetPackedA32(src[x]);
-                    if (alphaDst[0] != 0xFF) {
+                    uint32_t pixel = src[x];
+                    alphaDst[0] = SkGetPackedA32(pixel);
+                    if (alphaDst[0] != SK_AlphaOPAQUE) {
                         hasAlpha = true;
                     }
-                    if (alphaDst[0]) {
+                    if (alphaDst[0] != SK_AlphaTRANSPARENT) {
                         isTransparent = false;
                     }
+                    unpremultiply_and_pack_argb8888(alphaDst[0], pixel, dst);
                     alphaDst++;
+                    dst += 3;
                 }
             }
             break;