Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2232883002: Disable testCloseFiveIncognitoTab* tests (Closed)

Created:
4 years, 4 months ago by perezju
Modified:
4 years, 4 months ago
Reviewers:
Theresa, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable testCloseFiveIncognitoTab* tests Tests are failing on Android Tests (dbg), and Jelly Bean Tester. TBR=dfalcantara@chromium.org,twellington@chromium.org BUG=636344 Committed: https://crrev.com/af7dfbe1caf07ba720221ed293818a89674e71ed Cr-Commit-Position: refs/heads/master@{#411038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
perezju
4 years, 4 months ago (2016-08-10 14:09:17 UTC) #2
perezju
TBR'ing to bring Android Tests (dbg) out of red.
4 years, 4 months ago (2016-08-10 14:10:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232883002/1
4 years, 4 months ago (2016-08-10 14:10:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 14:47:31 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/af7dfbe1caf07ba720221ed293818a89674e71ed Cr-Commit-Position: refs/heads/master@{#411038}
4 years, 4 months ago (2016-08-10 14:49:21 UTC) #10
Theresa
4 years, 4 months ago (2016-08-10 18:11:26 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2236653002/ by twellington@chromium.org.

The reason for reverting is: The suspected CL was reverted and the current
Android Tests(dbg) build #35666 with that revert is passing on the
testCloseFiveIncognitoTab* tests. Reverting this CL so that we still get test
coverage (these are important tests)..

Powered by Google App Engine
This is Rietveld 408576698