chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h - Issue 2232863002: Remove search::GetSearchTerms since it always returns empty string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

Issue 2232863002: Remove search::GetSearchTerms since it always returns empty string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_query_extract

Patch Set: Android Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

index b4cc9d4aa32d3b41d021f1daac49e53b322e0edb..15f2c3197156db682384d97962b6624150392d15 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

@@ -101,8 +101,6 @@ class OmniboxViewMac : public OmniboxView,

bool CanCopy() override;

base::scoped_nsobject<NSPasteboardItem> CreatePasteboardItem() override;

void CopyToPasteboard(NSPasteboard* pboard) override;

- bool ShouldEnableShowURL() override;

- void ShowURL() override;

void OnPaste() override;

bool CanPasteAndGo() override;

int GetPasteActionStringId() override;

@@ -119,7 +117,6 @@ class OmniboxViewMac : public OmniboxView,

void OnSetFocus(bool control_down) override;

void OnKillFocus() override;

void OnMouseDown(NSInteger button_number) override;

- bool ShouldSelectAllOnMouseDown() override;

// Helper for LocationBarViewMac. Optionally selects all in |field_|.

void FocusLocation(bool select_all);