Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

Issue 2232863002: Remove search::GetSearchTerms since it always returns empty string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_query_extract
Patch Set: Android Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
index d837c4efa65d6f0992ef09537260d590337784d1..633e5cf09e7038bcbf0ce9299be1b7e2a49721e5 100644
--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
@@ -168,12 +168,6 @@ BOOL ThePasteboardIsTooDamnBig() {
[self delete:nil];
}
-- (void)showURL:(id)sender {
- AutocompleteTextFieldObserver* observer = [self observer];
- DCHECK(observer);
- observer->ShowURL();
-}
-
// This class assumes that the delegate is an AutocompleteTextField.
// Enforce that assumption.
- (AutocompleteTextField*)delegate {
@@ -308,16 +302,6 @@ BOOL ThePasteboardIsTooDamnBig() {
[menu addItem:[NSMenuItem separatorItem]];
- // Display a "Show URL" option if search term replacement is active.
- if (observer->ShouldEnableShowURL()) {
- NSString* showURLLabel =
- l10n_util::GetNSStringWithFixup(IDS_SHOW_URL_MAC);
- DCHECK([showURLLabel length]);
- [menu addItemWithTitle:showURLLabel
- action:@selector(showURL:)
- keyEquivalent:@""];
- }
-
NSString* searchEngineLabel =
l10n_util::GetNSStringWithFixup(IDS_EDIT_SEARCH_ENGINES);
DCHECK([searchEngineLabel length]);
@@ -586,11 +570,6 @@ BOOL ThePasteboardIsTooDamnBig() {
DCHECK(observer);
return observer->CanPasteAndGo();
}
- if ([item action] == @selector(showURL:)) {
- AutocompleteTextFieldObserver* observer = [self observer];
- DCHECK(observer);
- return observer->ShouldEnableShowURL();
- }
return [super validateMenuItem:item];
}

Powered by Google App Engine
This is Rietveld 408576698