Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: components/metrics/proto/omnibox_event.proto

Issue 2232863002: Remove search::GetSearchTerms since it always returns empty string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_query_extract
Patch Set: Android Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/search/search_types.h ('k') | components/omnibox/browser/omnibox_edit_model.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Stores information about an omnibox interaction. 5 // Stores information about an omnibox interaction.
6 6
7 syntax = "proto2"; 7 syntax = "proto2";
8 8
9 option optimize_for = LITE_RUNTIME; 9 option optimize_for = LITE_RUNTIME;
10 option java_outer_classname = "OmniboxEventProtos"; 10 option java_outer_classname = "OmniboxEventProtos";
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 // classify the page into those categories, not HOME_PAGE. 104 // classify the page into those categories, not HOME_PAGE.
105 HOME_PAGE = 3; 105 HOME_PAGE = 3;
106 106
107 // The catch-all entry of everything not included somewhere else 107 // The catch-all entry of everything not included somewhere else
108 // on this list. 108 // on this list.
109 OTHER = 4; 109 OTHER = 4;
110 110
111 // The instant new tab page enum value was deprecated on August 2, 2013. 111 // The instant new tab page enum value was deprecated on August 2, 2013.
112 OBSOLETE_INSTANT_NTP = 5; 112 OBSOLETE_INSTANT_NTP = 5;
113 113
114 // The user is on a search result page that's doing search term 114 // The search term replacement enum value was deprecated in August 2016.
115 // replacement, meaning the search terms should've appeared in the omnibox 115 OBSOLETE_SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6;
116 // before the user started editing it, not the URL of the page.
117 SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6;
118 116
119 // The new tab page in which this omnibox interaction first started 117 // The new tab page in which this omnibox interaction first started
120 // with the user having focus in the omnibox. 118 // with the user having focus in the omnibox.
121 INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS = 7; 119 INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS = 7;
122 120
123 // The new tab page in which this omnibox interaction first started 121 // The new tab page in which this omnibox interaction first started
124 // with the user having focus in the fakebox. 122 // with the user having focus in the fakebox.
125 INSTANT_NTP_WITH_FAKEBOX_AS_STARTING_FOCUS = 8; 123 INSTANT_NTP_WITH_FAKEBOX_AS_STARTING_FOCUS = 8;
126 124
127 // The user is on a search result page that's not doing search term 125 // The user is on a search result page that's not doing search term
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 // The number of times this provider returned a non-zero number of 275 // The number of times this provider returned a non-zero number of
278 // suggestions during this omnibox session. 276 // suggestions during this omnibox session.
279 // Note that each provider may define a session differently for its 277 // Note that each provider may define a session differently for its
280 // purposes. 278 // purposes.
281 optional int32 times_returned_results_in_session = 5; 279 optional int32 times_returned_results_in_session = 5;
282 } 280 }
283 // A list of diagnostic information about each provider. Providers 281 // A list of diagnostic information about each provider. Providers
284 // will appear at most once in this list. 282 // will appear at most once in this list.
285 repeated ProviderInfo provider_info = 12; 283 repeated ProviderInfo provider_info = 12;
286 } 284 }
OLDNEW
« no previous file with comments | « chrome/common/search/search_types.h ('k') | components/omnibox/browser/omnibox_edit_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698