Remove search::GetSearchTerms since it always returns empty string

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include <set>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 680 matching lines @@
 
   if (HasTextBeingDragged())
     CloseOmniboxPopup();
 
   return views::Textfield::OnMouseDragged(event);
 }
 
 void OmniboxViewViews::OnMouseReleased(const ui::MouseEvent& event) {
   views::Textfield::OnMouseReleased(event);
   if (event.IsOnlyLeftMouseButton() || event.IsOnlyRightMouseButton()) {
-    // When the user has clicked and released to give us focus, select all
-    // unless we're omitting the URL (in which case refining an existing query
-    // is common enough that we do click-to-place-cursor).
-    if (select_all_on_mouse_release_ &&
-        !controller()->GetToolbarModel()->WouldReplaceURL()) {
+    // When the user has clicked and released to give us focus, select all.

[Peter Kasting, 2016/08/13 05:03:44]

Nit: Move this comment above the line above, and then combine the nested
conditionals.

[Marc Treib, 2016/08/16 12:00:17]

Done.

+    if (select_all_on_mouse_release_) {
       // Select all in the reverse direction so as not to scroll the caret
       // into view and shift the contents jarringly.
       SelectAll(true);
     }
   }
   select_all_on_mouse_release_ = false;
 }
 
 bool OmniboxViewViews::OnKeyPressed(const ui::KeyEvent& event) {
   // Skip processing of [Alt]+<num-pad digit> Unicode alt key codes.
@@ skipping 161 matching lines @@
   // The location bar needs to repaint without a focus ring.
   if (ui::MaterialDesignController::IsModeMaterial())
     location_bar_view_->SchedulePaint();
 }
 
 bool OmniboxViewViews::IsCommandIdEnabled(int command_id) const {
   if (command_id == IDS_APP_PASTE)
     return !read_only() && !GetClipboardText().empty();
   if (command_id == IDS_PASTE_AND_GO)
     return !read_only() && model()->CanPasteAndGo(GetClipboardText());
+  // TODO(treib): Completely remove IDS_SHOW_URL. crbug.com/627747
   if (command_id == IDS_SHOW_URL)
-    return controller()->GetToolbarModel()->WouldReplaceURL();
+    return false;
   return Textfield::IsCommandIdEnabled(command_id) ||
          location_bar_view_->command_updater()->IsCommandEnabled(command_id);
 }
 
 base::string16 OmniboxViewViews::GetSelectionClipboardText() const {
   return SanitizeTextForPaste(Textfield::GetSelectionClipboardText());
 }
 
 void OmniboxViewViews::DoInsertChar(base::char16 ch) {
   // If |insert_char_time_| is not null, there's a pending insert char operation
@@ skipping 194 matching lines @@
       paste_position + 1, IDS_PASTE_AND_GO, IDS_PASTE_AND_GO);
 
   menu_contents->AddSeparator(ui::NORMAL_SEPARATOR);
 
   // Minor note: We use IDC_ for command id here while the underlying textfield
   // is using IDS_ for all its command ids. This is because views cannot depend
   // on IDC_ for now.
   menu_contents->AddItemWithStringId(IDC_EDIT_SEARCH_ENGINES,
       IDS_EDIT_SEARCH_ENGINES);
 }