Remove search::GetSearchTerms since it always returns empty string

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"
 
 #include <Carbon/Carbon.h>  // kVK_Return
 
 #include "base/mac/foundation_util.h"
 #include "base/memory/ptr_util.h"
@@ skipping 917 matching lines @@
 }
 
 void OmniboxViewMac::OnMouseDown(NSInteger button_number) {
   // Restore caret visibility whenever the user clicks in the the omnibox. This
   // is not always covered by OnSetFocus() because when clicking while the
   // omnibox has invisible focus does not trigger a new OnSetFocus() call.
   if (button_number == 0 || button_number == 1)
     model()->SetCaretVisibility(true);
 }
 
-bool OmniboxViewMac::ShouldSelectAllOnMouseDown() {
-  return !controller()->GetToolbarModel()->WouldPerformSearchTermReplacement(
-      false);
-}
-
 bool OmniboxViewMac::CanCopy() {
   const NSRange selection = GetSelectedRange();
   return selection.length > 0;
 }
 
 base::scoped_nsobject<NSPasteboardItem> OmniboxViewMac::CreatePasteboardItem() {
   DCHECK(CanCopy());
 
   const NSRange selection = GetSelectedRange();
   base::string16 text = base::SysNSStringToUTF16(
       [[field_ stringValue] substringWithRange:selection]);
 
-  // Copy the URL unless this is the search URL and it's being replaced by the
-  // Extended Instant API.
+  // Copy the URL.
   GURL url;
   bool write_url = false;
-  if (!controller()->GetToolbarModel()->WouldPerformSearchTermReplacement(
-      false)) {
-    model()->AdjustTextForCopy(selection.location, IsSelectAll(), &text, &url,
-                               &write_url);
-  }
+  model()->AdjustTextForCopy(selection.location, IsSelectAll(), &text, &url,
+                             &write_url);
 
   if (IsSelectAll())
     UMA_HISTOGRAM_COUNTS(OmniboxEditModel::kCutOrCopyAllTextHistogram, 1);
 
   NSString* nstext = base::SysUTF16ToNSString(text);
   if (write_url) {
     return ui::ClipboardUtil::PasteboardItemFromUrl(
         base::SysUTF8ToNSString(url.spec()), nstext);
   } else {
     return ui::ClipboardUtil::PasteboardItemFromString(nstext);
   }
 }
 
 void OmniboxViewMac::CopyToPasteboard(NSPasteboard* pboard) {
   [pboard clearContents];
   base::scoped_nsobject<NSPasteboardItem> item(CreatePasteboardItem());
   [pboard writeObjects:@[ item.get() ]];
 }
 
-void OmniboxViewMac::ShowURL() {
-  DCHECK(ShouldEnableShowURL());
-  OmniboxView::ShowURL();

[Peter Kasting, 2016/08/13 05:03:44]

Remember to eventually rip out the other call chain that leads to this function
(which I think goes through LocationBarView::ShowURL()), and then rip out the
function itself.

[Marc Treib, 2016/08/16 12:00:17]

Yup, follow-up on the way!

-}
-
 void OmniboxViewMac::OnPaste() {
   // This code currently expects |field_| to be focused.
   DCHECK([field_ currentEditor]);
 
   base::string16 text = GetClipboardText();
   if (text.empty()) {
     return;
   }
   NSString* s = base::SysUTF16ToNSString(text);
 
@@ skipping 12 matching lines @@
     // Force a Paste operation to trigger the text_changed code in
     // OnAfterPossibleChange(), even if identical contents are pasted
     // into the text box.
     state_before_change_.text.clear();
 
     [editor replaceCharactersInRange:selectedRange withString:s];
     [editor didChangeText];
   }
 }
 
-// TODO(dominich): Move to OmniboxView base class? Currently this is defined on
-// the AutocompleteTextFieldObserver but the logic is shared between all
-// platforms. Some refactor might be necessary to simplify this. Or at least
-// this method could call the OmniboxView version.
-bool OmniboxViewMac::ShouldEnableShowURL() {
-  return controller()->GetToolbarModel()->WouldReplaceURL();
-}
-
 bool OmniboxViewMac::CanPasteAndGo() {
   return model()->CanPasteAndGo(GetClipboardText());
 }
 
 int OmniboxViewMac::GetPasteActionStringId() {
   base::string16 text(GetClipboardText());
   DCHECK(model()->CanPasteAndGo(text));
   return model()->IsPasteAndSearch(text) ?
       IDS_PASTE_AND_SEARCH : IDS_PASTE_AND_GO;
 }
@@ skipping 124 matching lines @@
                               display_text);
   NSDictionary* notification_info = @{
       NSAccessibilityAnnouncementKey : announcement,
       NSAccessibilityPriorityKey :     @(NSAccessibilityPriorityHigh)
   };
   NSAccessibilityPostNotificationWithUserInfo(
       [field_ window],
       NSAccessibilityAnnouncementRequestedNotification,
       notification_info);
 }