DescriptionRevert of Fix Print Preview Alt + Left Arrow breakage (patchset #5 id:80001 of https://codereview.chromium.org/2215063002/ )
Reason for revert:
PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation is flaky on mac_chromium_rel_ng:
PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (run #1):
[ RUN ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation
[41473:1287:0810/034931:18891494657941:ERROR:native_widget_mac.mm(285)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
../../chrome/browser/printing/print_preview_dialog_controller_unittest.cc:240: Failure
Expected: (tiger_barb_preview_dialog) != (tiger_preview_dialog_2), actual: 0x7f9efc809a00 vs 0x7f9efc809a00
[ FAILED ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (89 ms)
BUG=636234
Original issue's description:
> Fix Print Preview Alt + Left Arrow breakage
>
> Fixing print preview closing in g-mail bug caused ALT + left
> arrow to break for certain cases. Changed condition for not
> closing dialog to be more specific.
>
> BUG=634237
>
> Committed: https://crrev.com/d65b6608c1349ba70606565b2bed9ff8b016473a
> Cr-Commit-Position: refs/heads/master@{#410717}
TBR=thestig@chromium.org,rbpotter@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634237
Committed: https://crrev.com/5290712a92d8c235d1d6e704fa5a34937a57e56a
Cr-Commit-Position: refs/heads/master@{#411030}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|