Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2232853002: Revert of Fix Print Preview Alt + Left Arrow breakage (Closed)

Created:
4 years, 4 months ago by foolip
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, rbpotter
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix Print Preview Alt + Left Arrow breakage (patchset #5 id:80001 of https://codereview.chromium.org/2215063002/ ) Reason for revert: PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation is flaky on mac_chromium_rel_ng: PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (run #1): [ RUN ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation [41473:1287:0810/034931:18891494657941:ERROR:native_widget_mac.mm(285)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &) ../../chrome/browser/printing/print_preview_dialog_controller_unittest.cc:240: Failure Expected: (tiger_barb_preview_dialog) != (tiger_preview_dialog_2), actual: 0x7f9efc809a00 vs 0x7f9efc809a00 [ FAILED ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (89 ms) BUG=636234 Original issue's description: > Fix Print Preview Alt + Left Arrow breakage > > Fixing print preview closing in g-mail bug caused ALT + left > arrow to break for certain cases. Changed condition for not > closing dialog to be more specific. > > BUG=634237 > > Committed: https://crrev.com/d65b6608c1349ba70606565b2bed9ff8b016473a > Cr-Commit-Position: refs/heads/master@{#410717} TBR=thestig@chromium.org,rbpotter@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634237 Committed: https://crrev.com/5290712a92d8c235d1d6e704fa5a34937a57e56a Cr-Commit-Position: refs/heads/master@{#411030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -95 lines) Patch
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_unittest.cc View 2 chunks +0 lines, -89 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
foolip
Created Revert of Fix Print Preview Alt + Left Arrow breakage
4 years, 4 months ago (2016-08-10 13:11:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232853002/1
4 years, 4 months ago (2016-08-10 13:11:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 13:12:42 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 13:13:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5290712a92d8c235d1d6e704fa5a34937a57e56a
Cr-Commit-Position: refs/heads/master@{#411030}

Powered by Google App Engine
This is Rietveld 408576698