Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issue 223283002: roll skia DEPS to 14052 (Closed)

Created:
6 years, 8 months ago by robertphillips
Modified:
6 years, 8 months ago
CC:
chromium-reviews, skia-team_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

roll skia DEPS to 14052 Old Skia revision: 14021 New Skia revision: 14052 Control CL: https://codereview.chromium.org/223273002 This CL was created by Skia's roll_deps.py script. Bypassing commit queue trybots: NOTRY=true R=rmistry@chromium.org

Patch Set 1 #

Patch Set 2 : reattaching #

Patch Set 3 : Update skia_library_opts.gyp #

Patch Set 4 : add define #

Patch Set 5 : yet another attempt to fix the opt gyp file #

Patch Set 6 : another attempt #

Patch Set 7 : update to Skia ToT #

Patch Set 8 : Roll to r14052 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M DEPS View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M skia/skia_library_opts.gyp View 1 2 3 4 5 6 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
The mac_asan compile failure is a bit worrisome but otherwise this looks 'good'. The discrepancies ...
6 years, 8 months ago (2014-04-03 11:56:55 UTC) #1
rmistry1
LGTM
6 years, 8 months ago (2014-04-03 11:58:16 UTC) #2
robertphillips
Committed patchset #2 manually as r261360 (presubmit successful).
6 years, 8 months ago (2014-04-03 12:03:26 UTC) #3
robertphillips
Here are the CLs in this roll attempt.
6 years, 8 months ago (2014-04-03 13:12:14 UTC) #4
robertphillips
https://code.google.com/p/skia/source/list?num=18&start=14039
6 years, 8 months ago (2014-04-03 13:12:24 UTC) #5
robertphillips
This was reverted in r261375 due to failing iOS compilation.
6 years, 8 months ago (2014-04-03 13:23:59 UTC) #6
robertphillips
6 years, 8 months ago (2014-04-03 13:39:18 UTC) #7

          

Powered by Google App Engine
This is Rietveld 408576698