Check allignment of sub heap allocation in vulkan

Check allignment of sub heap allocation in vulkan

Certain Vulkan devices will return difference alignment requirements for
a given allocation even if using the same heap. Thus we need to check
this alignment as well when deciding which subheap we want to use in our
memory allocation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2232803003

Committed: https://skia.googlesource.com/skia/+/6e90d42d3d5b8e51e60afbe97b27a0c16c2bacf1

[egdaniel, 2016-08-10 14:43:48]

Description was changed from

==========
Check allignment of sub heap allocation in vulkan

Certain Vulkan devices will return difference alignment requirements for
a given allocation even if using the same heap. Thus we need to check
this alignment as well when deciding which subheap we want to use in our
memory allocation.

BUG=skia:
==========

to

==========
Check allignment of sub heap allocation in vulkan

Certain Vulkan devices will return difference alignment requirements for
a given allocation even if using the same heap. Thus we need to check
this alignment as well when deciding which subheap we want to use in our
memory allocation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2232803003
==========

[egdaniel, 2016-08-10 14:46:04]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com, robertphillips@google.com

[egdaniel, 2016-08-10 14:46:05]

https://codereview.chromium.org/2232803003/diff/1/src/gpu/vk/GrVkMemory.cpp
File src/gpu/vk/GrVkMemory.cpp (right):

https://codereview.chromium.org/2232803003/diff/1/src/gpu/vk/GrVkMemory.cpp#n...
src/gpu/vk/GrVkMemory.cpp:473: SkASSERT(fSubHeaps[bestFitIndex]->alignment() ==
alignment);
This assert fires without the change

[robertphillips, 2016-08-10 14:54:39]

lgtm

[robertphillips, 2016-08-10 14:54:46]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 14:54:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 15:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 15:11:09]

Dry run: This issue passed the CQ dry run.

[egdaniel, 2016-08-10 15:28:52]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-08-10 15:29:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 15:29:56]

Description was changed from

==========
Check allignment of sub heap allocation in vulkan

Certain Vulkan devices will return difference alignment requirements for
a given allocation even if using the same heap. Thus we need to check
this alignment as well when deciding which subheap we want to use in our
memory allocation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2232803003
==========

to

==========
Check allignment of sub heap allocation in vulkan

Certain Vulkan devices will return difference alignment requirements for
a given allocation even if using the same heap. Thus we need to check
this alignment as well when deciding which subheap we want to use in our
memory allocation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2232803003

Committed:
https://skia.googlesource.com/skia/+/6e90d42d3d5b8e51e60afbe97b27a0c16c2bacf1
==========

[commit-bot: I haz the power, 2016-08-10 15:29:57]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6e90d42d3d5b8e51e60afbe97b27a0c16c2bacf1