chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java - Issue 2232783002: Support action button to fetch more content suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2232783002: Support action button to fetch more content suggestions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippetsbridge

Patch Set: Indent comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

index 043d0164a1ee40e0bb437170e62072b4ca16a047..5475610e1519dbe6fc068debccdaaea972442fee 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

@@ -5,6 +5,7 @@

package org.chromium.chrome.browser.ntp.cards;

import org.chromium.chrome.browser.ntp.snippets.CategoryStatus.CategoryStatusEnum;

+import org.chromium.chrome.browser.ntp.snippets.KnownCategories;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticleListItem;

import org.chromium.chrome.browser.ntp.snippets.SnippetHeaderListItem;

import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;

@@ -24,12 +25,14 @@ public class SuggestionsSection implements ItemGroup {

private final ProgressListItem mProgressIndicator = new ProgressListItem();

private final ActionListItem mMoreButton;

- public SuggestionsSection(List<SnippetArticleListItem> suggestions,

+ public SuggestionsSection(int category, List<SnippetArticleListItem> suggestions,

@CategoryStatusEnum int status, SuggestionsCategoryInfo info,

NewTabPageAdapter adapter) {

mInfo = info;

mHeader = new SnippetHeaderListItem(mInfo.getTitle());

- mMoreButton = null; // TODO(pke): Read from info => ? new ActionListItem() : null;

+ // TODO(pke): Replace the condition with "info.hasMoreButton()" once all other categories

+ // are supported by the C++ backend, too.

+ mMoreButton = (category == KnownCategories.BOOKMARKS) ? new ActionListItem(category) : null;

setSuggestions(suggestions, status, adapter);

}