components/ntp_snippets/ntp_snippets_service.cc - Issue 2232783002: Support action button to fetch more content suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.cc

Issue 2232783002: Support action button to fetch more content suggestions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippetsbridge

Patch Set: Refactor NewTabPageAdapterTest Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/content_suggestions_service.cc ('K') | « components/ntp_snippets/content_suggestions_service_unittest.cc ('k') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc » ('j') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_service.cc

diff --git a/components/ntp_snippets/ntp_snippets_service.cc b/components/ntp_snippets/ntp_snippets_service.cc

index 295acfbcd20c73bdc72e2300baca2449e4add84a..8809ad7b8bd1e614ed152cbfaae72cdc94fc1556 100644

--- a/components/ntp_snippets/ntp_snippets_service.cc

+++ b/components/ntp_snippets/ntp_snippets_service.cc

@@ -284,7 +284,7 @@ CategoryStatus NTPSnippetsService::GetCategoryStatus(Category category) {

CategoryInfo NTPSnippetsService::GetCategoryInfo(Category category) {

return CategoryInfo(

l10n_util::GetStringUTF16(IDS_NTP_ARTICLE_SUGGESTIONS_SECTION_HEADER),

- ContentSuggestionsCardLayout::FULL_CARD);

+ ContentSuggestionsCardLayout::FULL_CARD, false);

Marc Treib 2016/08/12 08:44:39 Also here: comment to explain what the "false" mea

Philipp Keck 2016/08/12 09:11:32 Done.

}

void NTPSnippetsService::DismissSuggestion(const std::string& suggestion_id) {