Command buffer: CopyTexSubImage3D should clear the 3D texture if it is uncleared

Command buffer: CopyTexSubImage3D should clear the 3D texture if it is uncleared

BUG=631934, 636626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3972370575795597962787da7449243bd1d5d57b
Cr-Commit-Position: refs/heads/master@{#411283}

[yunchao, 2016-08-10 06:34:11]

Description was changed from

==========
Command buffer: CopyTexSubImage3D should clear the entier 3D texture if it is
uncleared

BUG=
==========

to

==========
Command buffer: CopyTexSubImage3D should clear the entier 3D texture if it is
uncleared

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-08-10 06:35:24]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 06:35:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2016-08-10 07:06:42]

Description was changed from

==========
Command buffer: CopyTexSubImage3D should clear the entier 3D texture if it is
uncleared

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Command buffer: CopyTexSubImage3D should clear the 3D texture if it is uncleared

BUG=631934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-08-10 07:06:43]

yunchao.he@intel.com changed reviewers:
+ kbr@chromium.org, piman@chromium.org, qiankun.miao@intel.com, zmo@chromium.org

[commit-bot: I haz the power, 2016-08-10 07:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 07:29:25]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-08-10 08:33:56]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 08:34:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 09:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 09:39:29]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-08-10 13:42:24]

I tested this change against WebGL 2 CTS by Yizhou:
https://github.com/KhronosGroup/WebGL/pull/1960. It can fix that issue on my
Linux desktop. 

I will update the webgl expectation once the roll-in change at
https://codereview.chromium.org/2235673002/, and run the webgl 2 conformance
test on all bots.

PTAL. Thanks!

[Zhenyao Mo, 2016-08-10 20:27:20]

lgtm

https://codereview.chromium.org/2232743002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2232743002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:13314: // 2. out-of-bounds
reading, etc.
Can you file a bug for this?  Comments in the code could easily get lost.

[Ken Russell (switch to Gerrit), 2016-08-10 20:31:54]

I'm not an OWNER in this code but it looks good.

[yunchao, 2016-08-10 23:13:49]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 23:15:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2016-08-11 00:41:31]

Description was changed from

==========
Command buffer: CopyTexSubImage3D should clear the 3D texture if it is uncleared

BUG=631934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Command buffer: CopyTexSubImage3D should clear the 3D texture if it is uncleared

BUG=631934, 636626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-08-11 00:42:39]

On 2016/08/10 20:27:20, Zhenyao Mo wrote:
> lgtm
> 
>
https://codereview.chromium.org/2232743002/diff/20001/gpu/command_buffer/serv...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/2232743002/diff/20001/gpu/command_buffer/serv...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:13314: // 2. out-of-bounds
> reading, etc.
> Can you file a bug for this?  Comments in the code could easily get lost.

Done.

[commit-bot: I haz the power, 2016-08-11 01:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 01:36:43]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[yunchao, 2016-08-11 04:52:12]

The CQ bit was checked by yunchao.he@intel.com

[yunchao, 2016-08-11 04:52:13]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2232743002/#ps40001
(title: "update webgl 2 expectation")

[commit-bot: I haz the power, 2016-08-11 04:52:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 04:53:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 04:53:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yunchao, 2016-08-11 05:29:24]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2016-08-11 05:29:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 07:32:20]

Description was changed from

==========
Command buffer: CopyTexSubImage3D should clear the 3D texture if it is uncleared

BUG=631934, 636626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Command buffer: CopyTexSubImage3D should clear the 3D texture if it is uncleared

BUG=631934, 636626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-08-11 07:32:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 07:34:41]

Description was changed from

==========
Command buffer: CopyTexSubImage3D should clear the 3D texture if it is uncleared

BUG=631934, 636626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Command buffer: CopyTexSubImage3D should clear the 3D texture if it is uncleared

BUG=631934, 636626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3972370575795597962787da7449243bd1d5d57b
Cr-Commit-Position: refs/heads/master@{#411283}
==========

[commit-bot: I haz the power, 2016-08-11 07:34:42]

Patchset 3 (id:??) landed as
https://crrev.com/3972370575795597962787da7449243bd1d5d57b
Cr-Commit-Position: refs/heads/master@{#411283}