Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2232723002: Import compare_build_artifacts.py from isolate recipe module. (Closed)

Created:
4 years, 4 months ago by Yoshisato Yanagisawa
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, ghost stip (do not use), Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import compare_build_artifacts.py from isolate recipe module. Build determinism is necessary for improving try performance. If two test binaries are the same, we usually do not need to run the test. The imported script checks the two builds are the same and shows error if they are different. The script is imported to make it easy for chromium developers to update the script and blacklist json to keep the script updated. BUG=314403 Committed: https://crrev.com/6ff5a0f7921217fdfe82ea60f67cdfd86028a871 Cr-Commit-Position: refs/heads/master@{#413016}

Patch Set 1 #

Total comments: 9

Patch Set 2 : updated whitelist, added todo, auto select target. #

Patch Set 3 : updated Android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+605 lines, -0 lines) Patch
A tools/compare_build_artifacts/compare_build_artifacts.py View 1 2 1 chunk +596 lines, -0 lines 0 comments Download
A tools/compare_build_artifacts/deterministic_build_blacklist.json View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Yoshisato Yanagisawa
4 years, 4 months ago (2016-08-10 06:09:45 UTC) #2
M-A Ruel
+Mike about android files. lgtm with comments about a potential follow up change now that ...
4 years, 4 months ago (2016-08-10 13:15:09 UTC) #3
Yoshisato Yanagisawa
https://codereview.chromium.org/2232723002/diff/1/tools/compare_build_artifacts/compare_build_artifacts.py File tools/compare_build_artifacts/compare_build_artifacts.py (right): https://codereview.chromium.org/2232723002/diff/1/tools/compare_build_artifacts/compare_build_artifacts.py#newcode326 tools/compare_build_artifacts/compare_build_artifacts.py:326: 'accessibility_unittests.exe', On 2016/08/10 13:15:08, M-A Ruel wrote: > Expect ...
4 years, 4 months ago (2016-08-12 09:21:02 UTC) #4
Yoshisato Yanagisawa
https://codereview.chromium.org/2232723002/diff/1/tools/compare_build_artifacts/compare_build_artifacts.py File tools/compare_build_artifacts/compare_build_artifacts.py (right): https://codereview.chromium.org/2232723002/diff/1/tools/compare_build_artifacts/compare_build_artifacts.py#newcode28 tools/compare_build_artifacts/compare_build_artifacts.py:28: 'd8', On 2016/08/10 13:15:08, M-A Ruel wrote: > Mike, ...
4 years, 4 months ago (2016-08-17 09:30:21 UTC) #5
M-A Ruel
lgtm https://codereview.chromium.org/2232723002/diff/1/tools/compare_build_artifacts/compare_build_artifacts.py File tools/compare_build_artifacts/compare_build_artifacts.py (right): https://codereview.chromium.org/2232723002/diff/1/tools/compare_build_artifacts/compare_build_artifacts.py#newcode28 tools/compare_build_artifacts/compare_build_artifacts.py:28: 'd8', On 2016/08/17 09:30:21, Yoshisato Yanagisawa wrote: > ...
4 years, 4 months ago (2016-08-17 12:46:09 UTC) #6
Yoshisato Yanagisawa
Since Nico is OOO until 22th, let me change the reviewer.
4 years, 4 months ago (2016-08-18 05:56:40 UTC) #9
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-18 16:57:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232723002/40001
4 years, 4 months ago (2016-08-19 00:53:26 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-19 01:45:15 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 01:49:45 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6ff5a0f7921217fdfe82ea60f67cdfd86028a871
Cr-Commit-Position: refs/heads/master@{#413016}

Powered by Google App Engine
This is Rietveld 408576698