Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Side by Side Diff: chromeos/network/client_cert_resolver.cc

Issue 22327005: Automatically resolve ClientCertificatePatterns. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chromeos/network/client_cert_resolver.h"
6
7 #include <cert.h>
8 #include <certt.h> // for (SECCertUsageEnum) certUsageAnyCA
9 #include <pk11pub.h>
10
11 #include <algorithm>
12 #include <string>
13
14 #include "base/stl_util.h"
15 #include "base/task_runner.h"
16 #include "base/threading/worker_pool.h"
17 #include "base/time/time.h"
18 #include "chromeos/cert_loader.h"
19 #include "chromeos/dbus/dbus_thread_manager.h"
20 #include "chromeos/dbus/shill_service_client.h"
21 #include "chromeos/network/certificate_pattern.h"
22 #include "chromeos/network/client_cert_util.h"
23 #include "chromeos/network/managed_network_configuration_handler.h"
24 #include "chromeos/network/network_state.h"
25 #include "chromeos/network/network_state_handler.h"
26 #include "chromeos/network/network_ui_data.h"
27 #include "chromeos/network/onc/onc_constants.h"
28 #include "dbus/object_path.h"
29 #include "net/cert/x509_certificate.h"
30
31 namespace chromeos {
32
33 // Describes a network |network_path| for which a matching certificate |cert_id|
34 // was found.
35 struct ClientCertResolver::NetworkAndMatchingCert {
36 NetworkAndMatchingCert(const std::string& network_path,
37 client_cert::ConfigType config_type,
38 const std::string& cert_id)
39 : service_path(network_path),
40 cert_config_type(config_type),
41 pkcs11_id(cert_id) {}
42
43 std::string service_path;
44 client_cert::ConfigType cert_config_type;
45 // The id of the matching certificate.
46 std::string pkcs11_id;
47 };
48
49 typedef std::vector<ClientCertResolver::NetworkAndMatchingCert>
50 NetworkCertMatches;
51
52 namespace {
53
54 // Returns true if |vector| contains |value|.
55 template <class T>
56 bool ContainsValue(const std::vector<T>& vector, const T& value) {
57 return find(vector.begin(), vector.end(), value) != vector.end();
58 }
59
60 // Returns true if a private key for certificate |cert| is installed.
61 bool HasPrivateKey(const net::X509Certificate& cert) {
62 PK11SlotInfo* slot = PK11_KeyForCertExists(cert.os_cert_handle(), NULL, NULL);
63 if (!slot)
64 return false;
65
66 PK11_FreeSlot(slot);
67 return true;
68 }
69
70 // Describes a certificate which is issued by |issuer| (encoded as PEM).
71 struct CertAndIssuer {
72 CertAndIssuer(const scoped_refptr<net::X509Certificate>& certificate,
73 const std::string& issuer)
74 : cert(certificate),
75 pem_encoded_issuer(issuer) {}
76
77 scoped_refptr<net::X509Certificate> cert;
78 std::string pem_encoded_issuer;
79 };
80
81 bool CompareCertExpiration(const CertAndIssuer& a,
82 const CertAndIssuer& b) {
83 return (a.cert->valid_expiry() < b.cert->valid_expiry());
84 }
85
86 // Describes a network that is configured with the certificate pattern
87 // |client_cert_pattern|.
88 struct NetworkAndCertPattern {
89 NetworkAndCertPattern(const std::string& network_path,
90 client_cert::ConfigType config_type,
91 const CertificatePattern& pattern)
92 : service_path(network_path),
93 cert_config_type(config_type),
94 client_cert_pattern(pattern) {}
95 std::string service_path;
96 client_cert::ConfigType cert_config_type;
97 CertificatePattern client_cert_pattern;
98 };
99
100 // A unary predicate that returns true if the given CertAndIssuer matches the
101 // certificate pattern of the NetworkAndCertPattern.
102 struct MatchCertWithPattern {
103 MatchCertWithPattern(const NetworkAndCertPattern& pattern)
104 : net_and_pattern(pattern) {}
105
106 bool operator()(const CertAndIssuer& cert_and_issuer) {
107 const CertificatePattern& pattern = net_and_pattern.client_cert_pattern;
108 if (!pattern.issuer().Empty() &&
109 !client_cert::CertPrincipalMatches(pattern.issuer(),
110 cert_and_issuer.cert->issuer())) {
111 return false;
112 }
113 if (!pattern.issuer().Empty() &&
114 !client_cert::CertPrincipalMatches(pattern.issuer(),
115 cert_and_issuer.cert->subject())) {
116 return false;
117 }
118
119 const std::vector<std::string>& issuer_ca_pems = pattern.issuer_ca_pems();
120 if (!issuer_ca_pems.empty() &&
121 !ContainsValue(issuer_ca_pems, cert_and_issuer.pem_encoded_issuer)) {
122 return false;
123 }
124 return true;
125 }
126
127 NetworkAndCertPattern net_and_pattern;
128 };
129
130 // Searches for matches between |networks| and |certs| and writes matches to
131 // |matches|. Because this calls NSS functions and is potentially slow, it must
132 // be run on a worker thread.
133 void FindCertificateMatches(const net::CertificateList& certs,
134 std::vector<NetworkAndCertPattern>* networks,
135 NetworkCertMatches* matches) {
136 // Filter all client certs and determines each certificate's issuer, which is
137 // required for the pattern matching.
138 std::vector<CertAndIssuer> client_certs;
139 for (net::CertificateList::const_iterator it = certs.begin();
140 it != certs.end(); ++it) {
141 const net::X509Certificate& cert = **it;
142 if (cert.valid_expiry().is_null() || cert.HasExpired() ||
143 !HasPrivateKey(cert)) {
144 continue;
145 }
146 CERTCertificate* issuer =
147 CERT_FindCertIssuer(cert.os_cert_handle(), PR_Now(), certUsageAnyCA);
148 if (!issuer) {
149 LOG(ERROR) << "Couldn't find cert issuer.";
150 continue;
151 }
152 std::string pem_encoded_issuer;
153 if (!net::X509Certificate::GetPEMEncoded(issuer, &pem_encoded_issuer)) {
154 LOG(ERROR) << "Couldn't PEM-encode certificate.";
155 continue;
156 }
157 client_certs.push_back(CertAndIssuer(*it, pem_encoded_issuer));
158 }
159
160 std::sort(client_certs.begin(), client_certs.end(), &CompareCertExpiration);
161
162 for (std::vector<NetworkAndCertPattern>::const_iterator it =
163 networks->begin();
164 it != networks->end(); ++it) {
165 std::vector<CertAndIssuer>::iterator cert_it = std::find_if(
166 client_certs.begin(), client_certs.end(), MatchCertWithPattern(*it));
167 if (cert_it == client_certs.end()) {
168 LOG(WARNING) << "Couldn't find a matching client cert for network "
169 << it->service_path;
170 continue;
171 }
172 std::string pkcs11_id = CertLoader::GetPkcs11IdForCert(*cert_it->cert);
173 if (pkcs11_id.empty()) {
174 LOG(ERROR) << "Couldn't determine PKCS#11 ID.";
175 continue;
176 }
177 matches->push_back(ClientCertResolver::NetworkAndMatchingCert(
178 it->service_path, it->cert_config_type, pkcs11_id));
179 }
180 }
181
182 // Determine the type of the CertificatePattern configuration, i.e. is it a
stevenjb 2013/08/09 22:22:44 Determines
pneubeck (no reviews) 2013/08/09 22:46:44 Done.
183 // pattern within an EAP, IPsec or OpenVPN configuration.
184 client_cert::ConfigType OncToClientCertConfigurationType(
185 const base::DictionaryValue& network_config) {
186 using namespace ::chromeos::onc;
187
188 const base::DictionaryValue* wifi = NULL;
189 network_config.GetDictionaryWithoutPathExpansion(network_config::kWiFi,
190 &wifi);
191 if (wifi) {
192 const base::DictionaryValue* eap = NULL;
193 wifi->GetDictionaryWithoutPathExpansion(wifi::kEAP, &eap);
194 if (!eap)
195 return client_cert::CONFIG_TYPE_NONE;
196 return client_cert::CONFIG_TYPE_EAP;
197 }
198
199 const base::DictionaryValue* vpn = NULL;
200 network_config.GetDictionaryWithoutPathExpansion(network_config::kVPN, &vpn);
201 if (vpn) {
202 const base::DictionaryValue* openvpn = NULL;
203 vpn->GetDictionaryWithoutPathExpansion(vpn::kOpenVPN, &openvpn);
204 if (openvpn)
205 return client_cert::CONFIG_TYPE_OPENVPN;
206
207 const base::DictionaryValue* ipsec = NULL;
208 vpn->GetDictionaryWithoutPathExpansion(vpn::kIPsec, &ipsec);
209 if (ipsec)
210 return client_cert::CONFIG_TYPE_IPSEC;
211
212 return client_cert::CONFIG_TYPE_NONE;
213 }
214
215 const base::DictionaryValue* ethernet = NULL;
216 network_config.GetDictionaryWithoutPathExpansion(network_config::kEthernet,
217 &ethernet);
218 if (ethernet) {
219 const base::DictionaryValue* eap = NULL;
220 ethernet->GetDictionaryWithoutPathExpansion(wifi::kEAP, &eap);
221 if (eap)
222 return client_cert::CONFIG_TYPE_EAP;
223 return client_cert::CONFIG_TYPE_NONE;
224 }
225
226 return client_cert::CONFIG_TYPE_NONE;
227 }
228
229 void LogError(const std::string& service_path,
230 const std::string& dbus_error_name,
231 const std::string& dbus_error_message) {
232 network_handler::ShillErrorCallbackFunction(
233 "ClientCertResolver.SetProperties failed",
234 service_path,
235 network_handler::ErrorCallback(),
236 dbus_error_name,
237 dbus_error_message);
238 }
239
240 bool ClientCertificatesLoaded() {
241 if(!CertLoader::Get()->certificates_loaded()) {
242 VLOG(1) << "Certificates not loaded yet.";
243 return false;
244 }
245 if (!CertLoader::Get()->IsHardwareBacked()) {
246 VLOG(1) << "TPM is not available.";
247 return false;
248 }
249 return true;
250 }
251
252 } // namespace
253
254 ClientCertResolver::ClientCertResolver()
255 : network_state_handler_(NULL),
256 managed_network_config_handler_(NULL),
257 weak_ptr_factory_(this) {
258 }
259
260 ClientCertResolver::~ClientCertResolver() {
261 if (network_state_handler_)
262 network_state_handler_->RemoveObserver(this, FROM_HERE);
263 if (CertLoader::IsInitialized())
264 CertLoader::Get()->RemoveObserver(this);
265 if (managed_network_config_handler_)
266 managed_network_config_handler_->RemoveObserver(this);
267 }
268
269 void ClientCertResolver::Init(
270 NetworkStateHandler* network_state_handler,
271 ManagedNetworkConfigurationHandler* managed_network_config_handler) {
272 DCHECK(network_state_handler);
273 network_state_handler_ = network_state_handler;
274 network_state_handler_->AddObserver(this, FROM_HERE);
275
276 DCHECK(managed_network_config_handler);
277 managed_network_config_handler_ = managed_network_config_handler;
278 managed_network_config_handler_->AddObserver(this);
279
280 CertLoader::Get()->AddObserver(this);
281 }
282
283 void ClientCertResolver::SetSlowTaskRunnerForTest(
284 const scoped_refptr<base::TaskRunner>& task_runner) {
285 slow_task_runner_for_test_ = task_runner;
286 }
287
288 void ClientCertResolver::NetworkListChanged() {
289 if (!ClientCertificatesLoaded())
290 return;
291 // Configure only networks that were not configured before.
292
293 // We'll drop networks from |resolved_networks_|, which are not known anymore.
294 std::set<std::string> old_resolved_networks;
295 old_resolved_networks.swap(resolved_networks_);
296
297 NetworkStateList networks;
298 network_state_handler_->GetNetworkList(&networks);
299
300 NetworkStateList networks_to_check;
301 for (NetworkStateList::const_iterator it = networks.begin();
302 it != networks.end(); ++it) {
303 // If this network is not managed, it cannot have a ClientCertPattern.
304 // We do this check here addiationally to ResolveNetworks because it's cheap
305 // and prevents that |resolved_networks_| becomes to large.
306 if ((*it)->guid().empty())
307 continue;
308
309 const std::string& service_path = (*it)->path();
310 if (ContainsKey(old_resolved_networks, service_path)) {
311 resolved_networks_.insert(service_path);
312 continue;
313 }
314 networks_to_check.push_back(*it);
315 }
316
317 ResolveNetworks(networks_to_check);
318 }
319
320 void ClientCertResolver::OnCertificatesLoaded(
321 const net::CertificateList& cert_list,
322 bool initial_load) {
323 if (!ClientCertificatesLoaded())
324 return;
325 // Compare all networks with all certificates.
326 NetworkStateList networks;
327 network_state_handler_->GetNetworkList(&networks);
328 ResolveNetworks(networks);
329 }
330
331 void ClientCertResolver::PolicyApplied(const std::string& service_path) {
332 if (!ClientCertificatesLoaded())
333 return;
334 // Compare this network with all certificates.
335 const NetworkState* network =
336 network_state_handler_->GetNetworkState(service_path);
337 if (!network) {
338 LOG(ERROR) << "service path '" << service_path << "' unknown.";
339 return;
340 }
341 NetworkStateList networks;
342 networks.push_back(network);
343 ResolveNetworks(networks);
344 }
345
346 void ClientCertResolver::ResolveNetworks(
347 const NetworkStateList& networks) {
348 scoped_ptr<std::vector<NetworkAndCertPattern> > networks_with_pattern(
349 new std::vector<NetworkAndCertPattern>);
350
351 // Filter networks with ClientCertPattern. As ClientCertPatterns can only be
352 // set by policy, we check there.
353 for (NetworkStateList::const_iterator it = networks.begin();
354 it != networks.end(); ++it) {
355 const NetworkState* network = *it;
356
357 // In any case, don't check this network again in NetworkListChanged.
358 resolved_networks_.insert(network->path());
359
360 // If this network is not managed, it cannot have a ClientCertPattern.
361 if (network->guid().empty())
362 continue;
363
364 if (network->profile_path().empty()) {
365 LOG(ERROR) << "Network " << network->path()
366 << " has a GUID but not profile path";
367 continue;
368 }
369 const base::DictionaryValue* policy =
370 managed_network_config_handler_->FindPolicyByGuidAndProfile(
371 network->guid(), network->profile_path());
372
373 if (!policy) {
374 VLOG(1) << "The policy for network " << network->path() << " with GUID "
375 << network->guid() << " is not available yet.";
376 // Skip this network for now. Once the policy is loaded, PolicyApplied()
377 // will retry.
378 continue;
379 }
380
381 VLOG(2) << "Inspecting network " << network->path();
382 // TODO(pneubeck): Access the ClientCertPattern without relying on
383 // NetworkUIData, which also parses other things that we don't need here.
384 // The ONCSource is irrelevant here.
385 scoped_ptr<NetworkUIData> ui_data(
386 NetworkUIData::CreateFromONC(onc::ONC_SOURCE_NONE, *policy));
387
388 // Skip networks that don't have a ClientCertPattern.
389 if (ui_data->certificate_type() != CLIENT_CERT_TYPE_PATTERN)
390 continue;
391
392 client_cert::ConfigType config_type =
393 OncToClientCertConfigurationType(*policy);
394 if (config_type == client_cert::CONFIG_TYPE_NONE) {
395 LOG(ERROR) << "UIData contains a CertificatePattern, but the policy "
396 << "doesn't. Network: " << network->path();
397 continue;
398 }
399
400 networks_with_pattern->push_back(NetworkAndCertPattern(
401 network->path(), config_type, ui_data->certificate_pattern()));
402 }
403 if (networks_with_pattern->empty())
404 return;
405
406 VLOG(2) << "Start task for resolving client cert patterns.";
407 base::TaskRunner* task_runner = slow_task_runner_for_test_.get();
408 if (!task_runner)
409 task_runner = base::WorkerPool::GetTaskRunner(true /* task is slow */);
410
411 NetworkCertMatches* matches = new NetworkCertMatches;
412 task_runner->PostTaskAndReply(
413 FROM_HERE,
414 base::Bind(&FindCertificateMatches,
415 CertLoader::Get()->cert_list(),
416 base::Owned(networks_with_pattern.release()),
417 matches),
418 base::Bind(&ClientCertResolver::ConfigureCertificates,
419 weak_ptr_factory_.GetWeakPtr(),
420 base::Owned(matches)));
421 }
422
423 void ClientCertResolver::ConfigureCertificates(NetworkCertMatches* matches) {
424 for (NetworkCertMatches::const_iterator it = matches->begin();
425 it != matches->end(); ++it) {
426 VLOG(1) << "Configuring certificate of network " << it->service_path;
427 CertLoader* cert_loader = CertLoader::Get();
428 base::DictionaryValue shill_properties;
429 client_cert::SetShillProperties(it->cert_config_type,
430 cert_loader->tpm_token_slot(),
431 cert_loader->tpm_user_pin(),
432 &it->pkcs11_id,
433 &shill_properties);
434 DBusThreadManager::Get()->GetShillServiceClient()->
435 SetProperties(dbus::ObjectPath(it->service_path),
436 shill_properties,
437 base::Bind(&base::DoNothing),
438 base::Bind(&LogError, it->service_path));
439 network_state_handler_->RequestUpdateForNetwork(it->service_path);
440 }
441 }
442
443 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698