Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2232663002: Remove NetworkTimeTracker.UpdateTimeFetchAttempted histogram (Closed)

Created:
4 years, 4 months ago by estark
Modified:
4 years, 4 months ago
Reviewers:
Nicolas Zea, jwd, mab
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NetworkTimeTracker.UpdateTimeFetchAttempted histogram As mab@ predicted in https://codereview.chromium.org/2176373003/diff/1/components/network_time/network_time_tracker.cc#newcode391, NetworkTimeTracker.UpdateTimeFetchAttempted does not show anything interesting happening on Canary, so the UpdateTimeFetchValid and UpdateTimeFetchFailed histograms should be enough for our purposes. BUG=632419 Committed: https://crrev.com/f9a6bfb3670adb37cb84b14d13a1b4e46fa3e44e Cr-Commit-Position: refs/heads/master@{#412034}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mark histogram as obsolete instead of deleting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M components/network_time/network_time_tracker.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/network_time/network_time_tracker_unittest.cc View 14 chunks +0 lines, -15 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
estark
mab PTAL?
4 years, 4 months ago (2016-08-10 00:31:01 UTC) #2
mab
lgtm
4 years, 4 months ago (2016-08-10 00:35:16 UTC) #3
estark
zea: can you please review components/network_time_tracker? jwd: can you please review histograms.xml?
4 years, 4 months ago (2016-08-10 00:38:13 UTC) #5
jwd
https://codereview.chromium.org/2232663002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2232663002/diff/1/tools/metrics/histograms/histograms.xml#oldcode34840 tools/metrics/histograms/histograms.xml:34840: -<histogram name="NetworkTimeTracker.UpdateTimeFetchAttempted"> Instead of removing, can you set this ...
4 years, 4 months ago (2016-08-10 17:42:27 UTC) #6
estark
https://codereview.chromium.org/2232663002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2232663002/diff/1/tools/metrics/histograms/histograms.xml#oldcode34840 tools/metrics/histograms/histograms.xml:34840: -<histogram name="NetworkTimeTracker.UpdateTimeFetchAttempted"> On 2016/08/10 17:42:26, jwd wrote: > Instead ...
4 years, 4 months ago (2016-08-10 17:46:19 UTC) #7
jwd
histograms LGTM
4 years, 4 months ago (2016-08-10 18:41:43 UTC) #8
Nicolas Zea
lgtm
4 years, 4 months ago (2016-08-15 18:55:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232663002/20001
4 years, 4 months ago (2016-08-15 18:56:37 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 20:24:43 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 20:45:54 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9a6bfb3670adb37cb84b14d13a1b4e46fa3e44e
Cr-Commit-Position: refs/heads/master@{#412034}

Powered by Google App Engine
This is Rietveld 408576698