Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: src/heap/heap.cc

Issue 2232653003: Reland of "[heap] Switch to 500k pages" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Sweep immortal immovables ;) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index e7d7eedc2f49abf6eaff07a14c9180e5a602bb93..97cb77294de1136d5d53fec726713f038f786a5b 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -77,7 +77,7 @@ Heap::Heap()
// semispace_size_ should be a power of 2 and old_generation_size_ should
// be a multiple of Page::kPageSize.
max_semi_space_size_(8 * (kPointerSize / 4) * MB),
- initial_semispace_size_(Page::kPageSize),
+ initial_semispace_size_(MB),
max_old_generation_size_(700ul * (kPointerSize / 4) * MB),
initial_old_generation_size_(max_old_generation_size_ /
kInitalOldGenerationLimitFactor),
@@ -5429,15 +5429,18 @@ void Heap::PrintAlloctionsHash() {
void Heap::NotifyDeserializationComplete() {
deserialization_complete_ = true;
Hannes Payer (out of office) 2016/08/11 20:12:23 Can you move deserialization_complete_ = true; to
Michael Lippautz 2016/08/12 06:45:58 Done.
-#ifdef DEBUG
- // All pages right after bootstrapping must be marked as never-evacuate.
+ CHECK_EQ(0, gc_count());
Hannes Payer (out of office) 2016/08/11 20:12:23 DCHECK_EQ
Michael Lippautz 2016/08/12 06:45:59 Done.
+
PagedSpaces spaces(this);
for (PagedSpace* s = spaces.next(); s != NULL; s = spaces.next()) {
+ if (isolate()->snapshot_available()) s->ShrinkImmortalImmovablePages();
+#ifdef DEBUG
+ // All pages right after bootstrapping must be marked as never-evacuate.
for (Page* p : *s) {
CHECK(p->NeverEvacuate());
}
- }
#endif // DEBUG
+ }
}
void Heap::SetEmbedderHeapTracer(EmbedderHeapTracer* tracer) {
« no previous file with comments | « src/base/build_config.h ('k') | src/heap/mark-compact.cc » ('j') | src/heap/spaces.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698