Function name variable does not need a VariableDeclaration

Function name variable does not need a VariableDeclaration

This changes Scope::function_ (for holding the name binding
for named function expression) from a VariableDeclaration
to a Variable. No work is done when visiting this declaration,
since it's kCreatedInitialized, so we can treat it like
other function-specific variables.

This simplifies a wide variety of code, and centralizes
the logic for constructing the variable inside scopes.cc.
This may one day make it easier to eliminate the CONST_LEGACY
VariableMode.

R=neis@chromium.org, verwaest@chromium.org
BUG=v8:5209
Committed: https://crrev.com/73b0f15714755c61afbdd3fb3728c5155cc31baa
Cr-Commit-Position: refs/heads/master@{#38558}

[adamk, 2016-08-10 00:07:16]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 00:07:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-08-10 00:11:09]

Amusingly, it seems this became a VariableDeclaration as part of a refactoring
"in preparation for modules" four years ago:
https://codereview.chromium.org/9704054

[commit-bot: I haz the power, 2016-08-10 00:45:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 00:45:05]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-08-10 04:38:08]

nice! lgtm

[neis, 2016-08-10 09:38:47]

lgtm

[adamk, 2016-08-10 17:32:30]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:32:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 17:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:34:56]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21561)

[adamk, 2016-08-10 17:46:12]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-08-10 17:46:12]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org,
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2232633002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-08-10 17:46:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 18:45:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-10 18:46:04]

Description was changed from

==========
Function name variable does not need a VariableDeclaration

This changes Scope::function_ (for holding the name binding
for named function expression) from a VariableDeclaration
to a Variable. No work is done when visiting this declaration,
since it's kCreatedInitialized, so we can treat it like
other function-specific variables.

This simplifies a wide variety of code, and centralizes
the logic for constructing the variable inside scopes.cc.
This may one day make it easier to eliminate the CONST_LEGACY
VariableMode.

R=neis@chromium.org, verwaest@chromium.org
BUG=v8:5209
==========

to

==========
Function name variable does not need a VariableDeclaration

This changes Scope::function_ (for holding the name binding
for named function expression) from a VariableDeclaration
to a Variable. No work is done when visiting this declaration,
since it's kCreatedInitialized, so we can treat it like
other function-specific variables.

This simplifies a wide variety of code, and centralizes
the logic for constructing the variable inside scopes.cc.
This may one day make it easier to eliminate the CONST_LEGACY
VariableMode.

R=neis@chromium.org, verwaest@chromium.org
BUG=v8:5209

Committed: https://crrev.com/73b0f15714755c61afbdd3fb3728c5155cc31baa
Cr-Commit-Position: refs/heads/master@{#38558}
==========

[commit-bot: I haz the power, 2016-08-10 18:46:05]

Patchset 2 (id:??) landed as
https://crrev.com/73b0f15714755c61afbdd3fb3728c5155cc31baa
Cr-Commit-Position: refs/heads/master@{#38558}