Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2167)

Unified Diff: appengine/findit/waterfall/test/try_job_util_test.py

Issue 2232613002: Chop off platform name from step name (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Remove ' on ', simplification, and code review changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/try_job_util_test.py
diff --git a/appengine/findit/waterfall/test/try_job_util_test.py b/appengine/findit/waterfall/test/try_job_util_test.py
index 8e8a458eb17880177f9471675c31b6dfe8327bdd..becdeaefacf9657751a1ade871447c986d17023f 100644
--- a/appengine/findit/waterfall/test/try_job_util_test.py
+++ b/appengine/findit/waterfall/test/try_job_util_test.py
@@ -1268,6 +1268,14 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
signals, 'master1', 'builder1'),
['b.o'])
+ def testRemovePlatformFromStepName(self):
+ self.assertEqual('a_tests',
+ try_job_util._RemovePlatformFromStepName('a_tests on Platform'))
+ self.assertEqual('a_tests',
+ try_job_util._RemovePlatformFromStepName('a_tests on Other-Platform'))
+ self.assertEqual('a_tests',
+ try_job_util._RemovePlatformFromStepName('a_tests'))
+
def testGetSuspectedCLsWithFailuresNoHeuristicResult(self):
heuristic_result = None
expected_suspected_revisions = []
« no previous file with comments | « no previous file | appengine/findit/waterfall/try_job_util.py » ('j') | appengine/findit/waterfall/try_job_util.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698