test.py: Fix in CommandQueue to make sure we finish up correctly if an intermediate command failed

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 1555 matching lines @@
       } else {
         newState = dgraph.NodeState.UnableToRun;
       }
     }
     if (node.state != newState) {
       _graph.changeState(node, newState);
     }
   }
 }
 
-// TODO(kustermann): Add support for '--list' and '--verbose'!
-
 /*
  * [CommandQueue] will listen for nodes entering the NodeState.ENQUEUING state,
  * queue them up and run them. While nodes are processed they will be in the
  * NodeState.PROCESSING state. After running a command, the node will change
  * to a state of NodeState.Successfull or NodeState.Failed.
  *
  * It provides a synchronous stream [completedCommands] which provides the
  * [CommandOutputs] for the finished commands.
  *
  * It provides a [done] future, which will complete once there are no more
@@ skipping 27 matching lines @@
             graph.changeState(event.node, dgraph.NodeState.Processing);
             var command = event.node.userData;
             if (event.node.dependencies.length > 0) {
               _runQueue.addFirst(command);
             } else {
               _runQueue.add(command);
             }
             Timer.run(() => _tryRunNextCommand());
           }
     });
-    eventCondition((event) => event is dgraph.GraphSealedEvent).listen((_) {
-      _checkDone();
+    // We're finished if the graph is sealed and all nodes are in a finished
+    // state (Successfull, Failed or UnableToRun).
+    // So we're calling '_checkDone()' to check whether that condition is met
+    // and we can cleanup.
+    graph.events.listen((dgraph.GraphEvent event) {
+      if (event is dgraph.GraphSealedEvent) {
+        _checkDone();
+      } else if (event is dgraph.StateChangedEvent) {
+        if (event.to == dgraph.NodeState.UnableToRun) {
+          _checkDone();
+        }
+      }
     });
   }
 
   Stream<CommandOutput> get completedCommands => _commandOutputStream.stream;
 
   Future get done => _completer.future;
 
   void _tryRunNextCommand() {
     _checkDone();
 
@@ skipping 335 matching lines @@
       // [TestCase.isFinished] will return true if all commands were executed
       // or if a previous one failed.
       if (testCase.isFinished) {
         completeTestCase(testCase);
       }
     }
   }
 }
 
 
-
 class ProcessQueue {
   Map _globalConfiguration;
 
   bool _allTestsWereEnqueued = false;
 
   bool _listTests;
   Function _allDone;
   final dgraph.Graph _graph = new dgraph.Graph();
   List<EventListener> _eventListener;
 
@@ skipping 80 matching lines @@
     }
   }
 
   void eventAllTestsDone() {
     for (var listener in _eventListener) {
       listener.allDone();
     }
     _allDone();
   }
 }