Revert 215769 "linux_aura: Implement the static part of the dbus..."

Revert 215769 "linux_aura: Implement the static part of the dbus..."

> linux_aura: Implement the static part of the dbus menu for Unity.
> 
> In GTK, we get a menu in the Unity bar for free as long as we have a
> GtkMenuBar object in our GtkWindow. linux_aura doesn't use gtk widgets
> in the interface. So opportunistically dlopen libdbusmenu-glib and
> manually construct a hidden DbusmenuMenuItem* object tree.
> 
> This only ports the static parts of the menus; it doesn't port the
> History menu, which changes based on user actions.
> 
> BUG=265560
> 
> Review URL: https://chromiumcodereview.appspot.com/21187006

TBR=erg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215780

[kochi, 2013-08-06 03:25:04]

Committed patchset #1 manually as r215780.

[kochi, 2013-08-06 03:27:56]

This failed for ChromeOS Chrome build.

Could you look at this error log?

FAILED: g++ -MMD -MF
obj/chrome/browser/ui/views/frame/browser_ui.global_menu_bar_registrar_x11.o.d
-DANGLE_DX11 -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DENABLE_RLZ
-DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS=1 -DUSE_X11=1 -DOS_CHROMEOS=1
-DFILE_MANAGER_EXTENSION=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1
-DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1
-DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_PRINTING=1
-DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1
-DNACL_WINDOWS=0 -DNACL_LINUX=1 -DNACL_OSX=0 -DNACL_TARGET_SUBARCH=32
-DNACL_TARGET_ARCH=x86 -DNACL_BUILD_SUBARCH=32 -DNACL_BUILD_ARCH=x86
-DFULL_SAFE_BROWSING -DGL_GLEXT_PROTOTYPES -DUSE_LIBGPS
-DLIBPEERCONNECTION_LIB=1 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_ENABLE_INST_COUNT=0
-DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DSK_USE_POSIX_THREADS -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION
-DLIBXML_STATIC -DHUNSPELL_STATIC -DHUNSPELL_CHROME_CLIENT -DUSE_HUNSPELL
-DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH
-DGTEST_RELATIVE_PATH -DJSONCPP_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING
-DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DCHROMEOS
-DI18N_PHONENUMBERS_USE_ICU_REGEXP=1 -DI18N_PHONENUMBERS_NO_THREAD_SAFETY=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DOFFICIAL_BUILD
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../..
-Iobj/chrome/browser_ui.gen -Igen -Iobj/chrome/browser_ui.gen/chrome
-I../../third_party/khronos -I../../gpu -Igen/protoc_out
-I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome
-I../../net/third_party/nss/ssl -I../../third_party/skia/src/core
-I../../skia/config -I../../third_party/skia/include/config
-I../../third_party/skia/include/core
-I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/gpu/gl
-I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../skia/ext
-I../../third_party/cacheinvalidation/overrides
-I../../third_party/cacheinvalidation/src
-I../../third_party/cacheinvalidation/google/cacheinvalidation
-I../../third_party/icu/source/i18n -I../../third_party/icu/source/common
-I../../third_party/libusb/src/libusb
-I../../third_party/libxml/linux/include
-I../../third_party/libxml/src/include -I../../third_party/zlib
-Igen/ui/app_locale_settings -Igen/ui/ui_strings -Igen/ui/ui_resources
-Igen/components/strings -I../../third_party/leveldatabase/src/include
-I../../third_party/leveldatabase/src -I../../third_party/leveldatabase
-I../../third_party/libjingle/overrides
-I../../third_party/libjingle/source -I../../testing/gtest/include
-I../../third_party -I../../third_party/webrtc
-I../../third_party/jsoncpp/overrides/include
-I../../third_party/jsoncpp/source/include
-Igen/protoc_out/third_party/libphonenumber
-I../../third_party/libphonenumber/src -I../../third_party/npapi
-I../../third_party/npapi/bindings -I../../third_party/re2
-I../../v8/include -Igen/webkit -Igen/policy -Igen/ash_strings
-Igen/ash/ash_resources -Igen/ui/keyboard -Igen/ui/gl
-I../../third_party/mesa/src/include -I/usr/include32 -Werror -pthread
-fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter
-Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -g -pthread
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/nss
-I/usr/include/nspr -Wno-unknown-pragmas -I/usr/include/dbus-1.0
-I/usr/lib/dbus-1.0/include -m32 -mmmx -msse2 -O2 -fno-ident
-fdata-sections -ffunction-sections -fno-unwind-tables
-fno-asynchronous-unwind-tables -fno-rtti -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wsign-compare  -c
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc -o
obj/chrome/browser/ui/views/frame/browser_ui.global_menu_bar_registrar_x11.o
In file included from
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:5:
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.h:45:
error: ISO C++ forbids declaration of 'GDBusProxy' with no type
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.h:45:
error: expected ';' before '*' token
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc: In
member function 'void GlobalMenuBarRegistrarX11::OnWindowMapped(long
unsigned int)':
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:29:
error: 'registrar_proxy_' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc: In
member function 'void GlobalMenuBarRegistrarX11::OnWindowUnmapped(long
unsigned int)':
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:34:
error: 'registrar_proxy_' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc: In
constructor 'GlobalMenuBarRegistrarX11::GlobalMenuBarRegistrarX11()':
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:41:
error: class 'GlobalMenuBarRegistrarX11' does not have any field named
'registrar_proxy_'
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:46:
error: 'G_BUS_TYPE_SESSION' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:47:
error: expected type-specifier before 'GDBusProxyFlags'
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:47:
error: expected '>' before 'GDBusProxyFlags'
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:47:
error: expected '(' before 'GDBusProxyFlags'
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:47:
error: 'GDBusProxyFlags' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:48:
error: 'G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES' was not declared in this
scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:49:
error: 'G_DBUS_PROXY_FLAGS_DO_NOT_CONNECT_SIGNALS' was not declared in this
scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:50:
error: 'G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc: In
destructor 'GlobalMenuBarRegistrarX11::~GlobalMenuBarRegistrarX11()':
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:61:
error: 'registrar_proxy_' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc: In
member function 'void GlobalMenuBarRegistrarX11::RegisterXID(long unsigned
int)':
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:71:
error: 'registrar_proxy_' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:84:
error: 'G_DBUS_CALL_FLAGS_NONE' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:87:
error: 'g_dbus_proxy_call' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc: In
member function 'void GlobalMenuBarRegistrarX11::UnregisterXID(long
unsigned int)':
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:91:
error: 'registrar_proxy_' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:104:
error: 'G_DBUS_CALL_FLAGS_NONE' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:107:
error: 'g_dbus_proxy_call' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc: In
member function 'void GlobalMenuBarRegistrarX11::OnProxyCreated(GObject*,
GAsyncResult*)':
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:113:
error: 'GDBusProxy' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:113:
error: 'proxy' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:113:
error: 'g_dbus_proxy_new_for_bus_finish' was not declared in this scope
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc:123:
error: 'registrar_proxy_' was not declared in this scope
FAILED: g++ -MMD -MF
obj/chrome/browser/ui/views/frame/browser_ui.global_menu_bar_x11.o.d
-DANGLE_DX11 -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DENABLE_RLZ
-DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS=1 -DUSE_X11=1 -DOS_CHROMEOS=1
-DFILE_MANAGER_EXTENSION=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1
-DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1
-DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_PRINTING=1
-DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1
-DNACL_WINDOWS=0 -DNACL_LINUX=1 -DNACL_OSX=0 -DNACL_TARGET_SUBARCH=32
-DNACL_TARGET_ARCH=x86 -DNACL_BUILD_SUBARCH=32 -DNACL_BUILD_ARCH=x86
-DFULL_SAFE_BROWSING -DGL_GLEXT_PROTOTYPES -DUSE_LIBGPS
-DLIBPEERCONNECTION_LIB=1 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_ENABLE_INST_COUNT=0
-DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DSK_USE_POSIX_THREADS -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION
-DLIBXML_STATIC -DHUNSPELL_STATIC -DHUNSPELL_CHROME_CLIENT -DUSE_HUNSPELL
-DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH
-DGTEST_RELATIVE_PATH -DJSONCPP_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING
-DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DCHROMEOS
-DI18N_PHONENUMBERS_USE_ICU_REGEXP=1 -DI18N_PHONENUMBERS_NO_THREAD_SAFETY=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DOFFICIAL_BUILD
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../..
-Iobj/chrome/browser_ui.gen -Igen -Iobj/chrome/browser_ui.gen/chrome
-I../../third_party/khronos -I../../gpu -Igen/protoc_out
-I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome
-I../../net/third_party/nss/ssl -I../../third_party/skia/src/core
-I../../skia/config -I../../third_party/skia/include/config
-I../../third_party/skia/include/core
-I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/gpu/gl
-I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../skia/ext
-I../../third_party/cacheinvalidation/overrides
-I../../third_party/cacheinvalidation/src
-I../../third_party/cacheinvalidation/google/cacheinvalidation
-I../../third_party/icu/source/i18n -I../../third_party/icu/source/common
-I../../third_party/libusb/src/libusb
-I../../third_party/libxml/linux/include
-I../../third_party/libxml/src/include -I../../third_party/zlib
-Igen/ui/app_locale_settings -Igen/ui/ui_strings -Igen/ui/ui_resources
-Igen/components/strings -I../../third_party/leveldatabase/src/include
-I../../third_party/leveldatabase/src -I../../third_party/leveldatabase
-I../../third_party/libjingle/overrides
-I../../third_party/libjingle/source -I../../testing/gtest/include
-I../../third_party -I../../third_party/webrtc
-I../../third_party/jsoncpp/overrides/include
-I../../third_party/jsoncpp/source/include
-Igen/protoc_out/third_party/libphonenumber
-I../../third_party/libphonenumber/src -I../../third_party/npapi
-I../../third_party/npapi/bindings -I../../third_party/re2
-I../../v8/include -Igen/webkit -Igen/policy -Igen/ash_strings
-Igen/ash/ash_resources -Igen/ui/keyboard -Igen/ui/gl
-I../../third_party/mesa/src/include -I/usr/include32 -Werror -pthread
-fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter
-Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -g -pthread
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/nss
-I/usr/include/nspr -Wno-unknown-pragmas -I/usr/include/dbus-1.0
-I/usr/lib/dbus-1.0/include -m32 -mmmx -msse2 -O2 -fno-ident
-fdata-sections -ffunction-sections -fno-unwind-tables
-fno-asynchronous-unwind-tables -fno-rtti -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wsign-compare  -c
../../chrome/browser/ui/views/frame/global_menu_bar_x11.cc -o
obj/chrome/browser/ui/views/frame/browser_ui.global_menu_bar_x11.o
In file included from
../../chrome/browser/ui/views/frame/global_menu_bar_x11.cc:17:
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.h:45:
error: ISO C++ forbids declaration of 'GDBusProxy' with no type
../../chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.h:45:
error: expected ';' before '*' token
ninja: build stopped: subcommand failed.


On Tue, Aug 6, 2013 at 12:25 PM, <kochi@chromium.org> wrote:

> Committed patchset #1 manually as r215780.
>
>
https://codereview.chromium.**org/22326003/<https://codereview.chromium.org/2...
>



-- 
Takayoshi Kochi