Fix uninitialized fields in Printer::PPDFile.

chromeos/printing/printer_translator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/printing/printer_translator.h"
 
 #include <memory>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 19 matching lines @@
 const char kDescription[] = "description";
 const char kManufacturer[] = "manufacturer";
 const char kModel[] = "model";
 const char kUri[] = "uri";
 const char kPPD[] = "ppd";
 const char kUUID[] = "uuid";
 
 std::unique_ptr<Printer::PPDFile> DictionaryToPPDFile(
     const base::DictionaryValue* value) {
   std::unique_ptr<Printer::PPDFile> ppd = base::MakeUnique<Printer::PPDFile>();
-  int id = -1;
-  value->GetInteger(kPPDid, &id);
-  ppd->id = id;
-
-  std::string file_name;
-  if (value->GetString(kFileName, &file_name))
-    ppd->file_name = file_name;
-
-  int version_number = 0;
-  if (value->GetInteger(kVersionNumber, &version_number))
-    ppd->version_number = version_number;
-
-  bool from_quirks;
-  if (value->GetBoolean(kFromQuirks, &from_quirks))
-    ppd->from_quirks_server = from_quirks;
-
+  // struct PPDFile defines default values for these fields so there is no need
+  // to check return values.
+  value->GetInteger(kPPDid, &ppd->id);
+  value->GetString(kFileName, &ppd->file_name);
+  value->GetInteger(kVersionNumber, &ppd->version_number);
+  value->GetBoolean(kFromQuirks, &ppd->from_quirks_server);
   return ppd;
 }
 
 std::unique_ptr<base::DictionaryValue> PPDFileToDictionary(
     const Printer::PPDFile& ppd) {
   std::unique_ptr<base::DictionaryValue> dictionary =
       base::MakeUnique<base::DictionaryValue>();
   dictionary->SetInteger(kPPDid, ppd.id);
   dictionary->SetString(kFileName, ppd.file_name);
   dictionary->SetInteger(kVersionNumber, ppd.version_number);
@@ skipping 60 matching lines @@
   dictionary->SetString(kUUID, printer.uuid());
 
   dictionary->Set(kPPD, PPDFileToDictionary(printer.ppd()));
 
   return dictionary;
 }
 
 }  // namespace printing
 
 }  // namespace chromeos