Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 223253006: Exclude references to EGL and relevant files when building chromecast as the current version of chr… (Closed)

Created:
6 years, 8 months ago by lcwu1
Modified:
6 years, 6 months ago
Reviewers:
danakj, jam, no sievers, piman
CC:
chromium-reviews, piman+watch_chromium.org, damienv1, kollas, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add necessary EGL name declarations/definitions and several native widget types for chromecast build. BUG=336640

Patch Set 1 #

Patch Set 2 : Add necessary EGL name declarations/definitions and native widget #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M ui/gfx/native_widget_types.h View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 3 chunks +8 lines, -1 line 0 comments Download
M ui/gl/gl_implementation.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
lcwu1
6 years, 8 months ago (2014-04-03 09:14:14 UTC) #1
no sievers
What are you trying to fix? A compilation problem? If so, I think the real ...
6 years, 8 months ago (2014-04-03 18:41:19 UTC) #2
lcwu1
On 2014/04/03 18:41:19, sievers wrote: > What are you trying to fix? A compilation problem? ...
6 years, 8 months ago (2014-04-03 23:36:17 UTC) #3
lcwu1
Patch set 2 uploaded. PTAL.
6 years, 8 months ago (2014-04-03 23:54:19 UTC) #4
no sievers
Cool, lgtm.
6 years, 8 months ago (2014-04-04 00:12:08 UTC) #5
lcwu1
6 years, 6 months ago (2014-06-24 22:43:32 UTC) #6
This CL is no longer needed (as we moved to use aura + ozone) and will be
closed.

Powered by Google App Engine
This is Rietveld 408576698