Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 223253005: Fix a problem that video does not show up in AW Shell. (Closed)

Created:
6 years, 8 months ago by Sungmann Cho
Modified:
6 years, 8 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix a problem that video does not show up in AW Shell. AW Shell shows a white screen when we play a video. It only plays sound. This patch implements onShowCustomView() and onHideCustomView() of AwContentsClient to fix it up. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sungmann Cho
Please take a look. Thanks.
6 years, 8 months ago (2014-04-03 08:36:51 UTC) #1
benm (inactive)
lgtm thanks for the patch!
6 years, 8 months ago (2014-04-03 10:30:21 UTC) #2
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 8 months ago (2014-04-03 10:42:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/223253005/1
6 years, 8 months ago (2014-04-03 10:43:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 14:59:17 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 14:59:17 UTC) #6
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 8 months ago (2014-04-03 15:05:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/223253005/1
6 years, 8 months ago (2014-04-03 15:05:44 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 15:09:36 UTC) #9
Message was sent while issue was closed.
Change committed as 261402

Powered by Google App Engine
This is Rietveld 408576698