Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 22325015: Load resources from chrome.pak instead of chrome.dll on windows (Closed)

Created:
7 years, 4 months ago by jamesr
Modified:
7 years, 4 months ago
Reviewers:
tony
CC:
chromium-reviews, scottmg
Visibility:
Public.

Description

Load resources from chrome.pak instead of chrome.dll on windows BUG=269777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M chrome/chrome_dll.gypi View 3 chunks +0 lines, -21 lines 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
This moves all resources out of chrome.dll except for the version info and chrome_dll_rc, which ...
7 years, 4 months ago (2013-08-08 19:35:25 UTC) #1
jamesr
It might be easier to just fold everything into resources.pak at the same time so ...
7 years, 4 months ago (2013-08-08 19:37:13 UTC) #2
tony
LGTM, but you probably want to include the packaging scripts in the same commit since ...
7 years, 4 months ago (2013-08-08 19:51:57 UTC) #3
jamesr
There are some places in other repos that'll have to be updated for windows too, ...
7 years, 4 months ago (2013-08-08 19:56:09 UTC) #4
jamesr
7 years, 4 months ago (2013-08-09 20:50:18 UTC) #5
On 2013/08/08 19:56:09, jamesr wrote:
> There are some places in other repos that'll have to be updated for windows
too,
> so I think I'm going to just fold chrome.pak into resources.pak too.

Done here: https://codereview.chromium.org/22325015/, closing this.

Powered by Google App Engine
This is Rietveld 408576698