Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2232483002: [turbofan] Add support for keyed access to strings. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Yang, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for keyed access to strings. This introduces initial support to handle keyed load access to String primitives. This is accomplished via the existing operators StringCharCodeAt and StringFromCharCode, which we already use to optimize String.prototype.charCodeAt and String.fromCharCode. R=yangguo@chromium.org BUG=v8:5267 Committed: https://crrev.com/3909250a6c7ae0003a1d54a3d47ec32260e4ede4 Cr-Commit-Position: refs/heads/master@{#38512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -150 lines) Patch
M src/compiler/js-native-context-specialization.cc View 2 chunks +180 lines, -150 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-09 18:30:05 UTC) #1
Toon Verwaest
lgtm. you probably want to clean up that MapList business in the future :)
4 years, 4 months ago (2016-08-10 04:31:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232483002/1
4 years, 4 months ago (2016-08-10 04:31:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 04:33:26 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 04:33:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3909250a6c7ae0003a1d54a3d47ec32260e4ede4
Cr-Commit-Position: refs/heads/master@{#38512}

Powered by Google App Engine
This is Rietveld 408576698