Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2232443002: [DevTools] Remove SimpleInspector (Closed)

Created:
4 years, 4 months ago by eostroukhov
Modified:
4 years, 4 months ago
Reviewers:
kozy, dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove SimpleInspector R=dgozman, pfeldman BUG= Committed: https://crrev.com/79a2141db29fc1c5d9215ab4d112c63a67f39028 Cr-Commit-Position: refs/heads/master@{#410799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -99 lines) Patch
D third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp View 1 chunk +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
eostroukhov
4 years, 4 months ago (2016-08-09 18:12:36 UTC) #2
dgozman
lgtm
4 years, 4 months ago (2016-08-09 20:21:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232443002/1
4 years, 4 months ago (2016-08-09 20:28:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 20:34:54 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 20:36:46 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/79a2141db29fc1c5d9215ab4d112c63a67f39028
Cr-Commit-Position: refs/heads/master@{#410799}

Powered by Google App Engine
This is Rietveld 408576698