Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2232423002: [layoutng] Move LayoutBox knowledge out of the NGBoxIterator (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Move LayoutBox knowledge out of the NGBoxIterator There is no need for the iterator to know about layout objects/boxes; we can just add and use a nextSibling() method on NGBox. This will simplify a possible future change to allow NGBox objects to work even without an attached layout object. (Such functionality would be especially useful for unit tests at the moment) R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org BUG=635619 Committed: https://crrev.com/7e8f79d3410922d7e9c712062f249a4577359c63 Cr-Commit-Position: refs/heads/master@{#411497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.h View 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box_iterator.h View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box_iterator.cc View 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
cbiesinger
4 years, 4 months ago (2016-08-11 21:36:38 UTC) #1
eae
LGTM
4 years, 4 months ago (2016-08-11 21:38:51 UTC) #4
ikilpatrick
lgtm
4 years, 4 months ago (2016-08-11 21:39:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232423002/1
4 years, 4 months ago (2016-08-11 21:41:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 00:55:37 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 00:57:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e8f79d3410922d7e9c712062f249a4577359c63
Cr-Commit-Position: refs/heads/master@{#411497}

Powered by Google App Engine
This is Rietveld 408576698