Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2232373003:
Fix reference result for compositing/transitions/transform-on-large-layer (Closed)
|
Created:
4 years, 4 months ago by Stephen Chennney Modified:
4 years, 4 months ago Reviewers:
ajuma CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, Eric Willigers Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix reference result for compositing/transitions/transform-on-large-layer
Apply the same resizing method to the reference result as is used on the test.
R=ajuma@chromium.org
BUG=245556, 636475
Committed: https://crrev.com/3ebd57ab640c504fac9139041188e61b3d92df20
Cr-Commit-Position: refs/heads/master@{#412553}
Patch Set 1 #Patch Set 2 : Match expectation resize behavior to actual #
Messages
Total messages: 23 (15 generated)
The CQ bit was checked by schenney@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/11 20:57:36, Stephen Chennney wrote: > PTAL Would it help to use the same resize approach in the reference that's used in the test itself (that is, making the test waitUntilDone and then notifyDone when the resize happens)?
On 2016/08/11 21:33:54, ajuma (OOO till Aug. 15) wrote: > On 2016/08/11 20:57:36, Stephen Chennney wrote: > > PTAL > > Would it help to use the same resize approach in the reference that's used in > the test itself (that is, making the test waitUntilDone and then notifyDone when > the resize happens)? Yes. I'll try that out. Still wondering why the different platforms show different sizes. Maybe some respect the resize and some don't.
The CQ bit was checked by schenney@chromium.org to run a CQ dry run
The CQ bit was unchecked by schenney@chromium.org
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by schenney@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Switch to pixel results for compositing/transitions/transform-on-large-layer This was a reference test, but the reference didn't seem to apply the resize of the window, resulting in incorrect results in almost every case. R=ajuma@chromium.org BUG=245556,636475 ========== to ========== Fix reference result for compositing/transitions/transform-on-large-layer Apply the same resizing method to the reference result as is used on the test. R=ajuma@chromium.org BUG=245556,636475 ==========
On 2016/08/12 20:48:38, Stephen Chennney wrote: > On 2016/08/11 21:33:54, ajuma (OOO till Aug. 15) wrote: > > On 2016/08/11 20:57:36, Stephen Chennney wrote: > > > PTAL > > > > Would it help to use the same resize approach in the reference that's used in > > the test itself (that is, making the test waitUntilDone and then notifyDone > when > > the resize happens)? > > Yes. I'll try that out. Still wondering why the different platforms show > different sizes. Maybe some respect the resize and some don't. Looks like updating the resize behavior on the reference result did indeed fix the issue. The Windows try failure is unrelated. Thanks for pushing me to look at it again.
On 2016/08/17 14:21:54, Stephen Chennney wrote: > On 2016/08/12 20:48:38, Stephen Chennney wrote: > > On 2016/08/11 21:33:54, ajuma (OOO till Aug. 15) wrote: > > > On 2016/08/11 20:57:36, Stephen Chennney wrote: > > > > PTAL > > > > > > Would it help to use the same resize approach in the reference that's used > in > > > the test itself (that is, making the test waitUntilDone and then notifyDone > > when > > > the resize happens)? > > > > Yes. I'll try that out. Still wondering why the different platforms show > > different sizes. Maybe some respect the resize and some don't. > > Looks like updating the resize behavior on the reference result did indeed fix > the issue. The Windows try failure is unrelated. > > Thanks for pushing me to look at it again. Thanks, lgtm
The CQ bit was checked by schenney@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix reference result for compositing/transitions/transform-on-large-layer Apply the same resizing method to the reference result as is used on the test. R=ajuma@chromium.org BUG=245556,636475 ========== to ========== Fix reference result for compositing/transitions/transform-on-large-layer Apply the same resizing method to the reference result as is used on the test. R=ajuma@chromium.org BUG=245556,636475 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix reference result for compositing/transitions/transform-on-large-layer Apply the same resizing method to the reference result as is used on the test. R=ajuma@chromium.org BUG=245556,636475 ========== to ========== Fix reference result for compositing/transitions/transform-on-large-layer Apply the same resizing method to the reference result as is used on the test. R=ajuma@chromium.org BUG=245556,636475 Committed: https://crrev.com/3ebd57ab640c504fac9139041188e61b3d92df20 Cr-Commit-Position: refs/heads/master@{#412553} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3ebd57ab640c504fac9139041188e61b3d92df20 Cr-Commit-Position: refs/heads/master@{#412553} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
