Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2232353002:
Call GetBrowser() from RenderViewContextMenu::IsRouteMediaEnabled() (Closed)
DescriptionCall GetBrowser() from IsRouteMediaEnabled()
This fixes the issue of the "Cast..." context menu option being disabled in the PDF viewer.
BUG=602177
Committed: https://crrev.com/33de42c61b10edda23bfbafdeba9ae3c425b94db
Cr-Commit-Position: refs/heads/master@{#412101}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address Istiaque's comment #Messages
Total messages: 22 (15 generated)
Patchset #2 (id:20001) has been deleted
Description was changed from ========== . BUG= ========== to ========== Call GetBrowser() from IsRouteMediaEnabled() This fixes the issue of the "Cast..." context menu option being disabled in the PDF viewer. BUG=602177 ==========
takumif@chromium.org changed reviewers: + lazyboy@chromium.org
Please take a look, thank you!
https://codereview.chromium.org/2232353002/diff/1/chrome/browser/renderer_con... File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/2232353002/diff/1/chrome/browser/renderer_con... chrome/browser/renderer_context_menu/render_view_context_menu.cc:2380: Browser* browser = I think you need to change this? Also |source_web_contents_| below crashes for me locally when I tried.
Sorry, you're right. Fixed. https://codereview.chromium.org/2232353002/diff/1/chrome/browser/renderer_con... File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/2232353002/diff/1/chrome/browser/renderer_con... chrome/browser/renderer_context_menu/render_view_context_menu.cc:2380: Browser* browser = On 2016/08/11 18:52:40, lazyboy wrote: > I think you need to change this? > > Also |source_web_contents_| below crashes for me locally when I tried. Done.
On 2016/08/15 16:40:10, takumif wrote: > Sorry, you're right. Fixed. > > https://codereview.chromium.org/2232353002/diff/1/chrome/browser/renderer_con... > File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): > > https://codereview.chromium.org/2232353002/diff/1/chrome/browser/renderer_con... > chrome/browser/renderer_context_menu/render_view_context_menu.cc:2380: Browser* > browser = > On 2016/08/11 18:52:40, lazyboy wrote: > > I think you need to change this? > > > > Also |source_web_contents_| below crashes for me locally when I tried. > > Done. lgtm assuming this works.
The CQ bit was checked by takumif@chromium.org to run a CQ dry run
The CQ bit was unchecked by takumif@chromium.org
The CQ bit was checked by takumif@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by takumif@chromium.org
The CQ bit was checked by takumif@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by takumif@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Call GetBrowser() from IsRouteMediaEnabled() This fixes the issue of the "Cast..." context menu option being disabled in the PDF viewer. BUG=602177 ========== to ========== Call GetBrowser() from IsRouteMediaEnabled() This fixes the issue of the "Cast..." context menu option being disabled in the PDF viewer. BUG=602177 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Call GetBrowser() from IsRouteMediaEnabled() This fixes the issue of the "Cast..." context menu option being disabled in the PDF viewer. BUG=602177 ========== to ========== Call GetBrowser() from IsRouteMediaEnabled() This fixes the issue of the "Cast..." context menu option being disabled in the PDF viewer. BUG=602177 Committed: https://crrev.com/33de42c61b10edda23bfbafdeba9ae3c425b94db Cr-Commit-Position: refs/heads/master@{#412101} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/33de42c61b10edda23bfbafdeba9ae3c425b94db Cr-Commit-Position: refs/heads/master@{#412101} |
