Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 223233002: Mojo: Move mojo/public/bindings/js to mojo/public/js/bindings. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Move mojo/public/bindings/js to mojo/public/js/bindings. The presence of constants.{cc,h} still seems very odd to me, and I still need to figure out what to do with them (even though I moved them anyway). R=sky@chromium.org TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261679

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 2

Patch Set 3 : rebase & restore ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -771 lines) Patch
M content/browser/webui/web_ui_data_source_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/web_ui_mojo.js View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/bindings/connection_unittests.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/main.js View 1 chunk +1 line, -1 line 0 comments Download
M mojo/bindings/js/codec_unittests.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_apps_js_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_js_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/bindings/generators/js_templates/module.js.tmpl View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/bindings/js/codec.js View 1 chunk +0 lines, -505 lines 0 comments Download
D mojo/public/bindings/js/connection.js View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/public/bindings/js/connector.js View 1 chunk +0 lines, -103 lines 0 comments Download
D mojo/public/bindings/js/constants.h View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/public/bindings/js/constants.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/public/bindings/js/router.js View 1 chunk +0 lines, -75 lines 0 comments Download
A + mojo/public/js/bindings/codec.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/bindings/connection.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/js/bindings/connector.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/js/bindings/constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A mojo/public/js/bindings/constants.cc View 1 chunk +14 lines, -0 lines 0 comments Download
A + mojo/public/js/bindings/router.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-03 04:18:28 UTC) #1
viettrungluu
-> sky
6 years, 8 months ago (2014-04-03 22:04:05 UTC) #2
sky
https://codereview.chromium.org/223233002/diff/20001/mojo/apps/js/bindings/connection_unittests.js File mojo/apps/js/bindings/connection_unittests.js (right): https://codereview.chromium.org/223233002/diff/20001/mojo/apps/js/bindings/connection_unittests.js#newcode55 mojo/apps/js/bindings/connection_unittests.js:55: "mojo/public/js/bindings/connection", If you move this, then you need to ...
6 years, 8 months ago (2014-04-03 22:09:32 UTC) #3
viettrungluu
PTAL. I restored the original order (I'll take care of sorting separately[*]). Whoever thought that ...
6 years, 8 months ago (2014-04-04 03:13:07 UTC) #4
sky
LGTM Ya, I'm not sure why they didn't go with an array of tuples:(
6 years, 8 months ago (2014-04-04 03:36:24 UTC) #5
viettrungluu
TBR brettw for content OWNERS
6 years, 8 months ago (2014-04-04 04:55:18 UTC) #6
viettrungluu
Committed patchset #3 manually as r261679 (presubmit successful).
6 years, 8 months ago (2014-04-04 04:56:02 UTC) #7
darin (slow to review)
6 years, 8 months ago (2014-04-04 22:42:27 UTC) #8
Message was sent while issue was closed. 
src/content/ LGTM

Powered by Google App Engine
This is Rietveld 408576698