Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2232283003: Revert of SkPDF: Subset Type3 (fallback) font (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@SkPDF_next3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkPDF: Subset Type3 (fallback) font (patchset #8 id:200001 of https://codereview.chromium.org/2231483002/ ) Reason for revert: internal failing Original issue's description: > SkPDF: Subset Type3 (fallback) font > > Motivation: significant file-size reduction. > > Also: SkPDFFont::subsetFont() returns a sk_sp<SkPDFObject> > rather than a SkPDFFont*. > > SkPDFType3Font constructor no longer populates font info; > relies on subsetting. > > SkPDFFont::Create is easier to read > > Also: SkPDFType3Font are scaled by emSize rather than 1000. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231483002 > > Committed: https://skia.googlesource.com/skia/+/88b138da99328b04cae9a8ee19c3882b8847a550 TBR=bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/5bf60adaaf76a102514b420a4acff6083902dabc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -214 lines) Patch
M src/pdf/SkPDFDocument.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFFont.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFFont.cpp View 10 chunks +105 lines, -208 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hal.canary
Created Revert of SkPDF: Subset Type3 (fallback) font
4 years, 4 months ago (2016-08-11 20:59:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232283003/1
4 years, 4 months ago (2016-08-11 20:59:12 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 20:59:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5bf60adaaf76a102514b420a4acff6083902dabc

Powered by Google App Engine
This is Rietveld 408576698