Delete site/try

Delete site/try

R=het@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/2ee3b9fae66ecd29a5898a803319cf2e384ea95d

[Siggi Cherem (dart-lang), 2016-08-12 16:52:28]

sigmund@google.com changed reviewers:
+ ahe@google.com, het@google.com

[Siggi Cherem (dart-lang), 2016-08-12 16:52:30]

https://codereview.chromium.org/2232273004/diff/1/dart.gyp
File dart.gyp (left):

https://codereview.chromium.org/2232273004/diff/1/dart.gyp#oldcode126
dart.gyp:126: 'target_name': 'dart2js_bot_debug',
Bill - I checked the bot recipes and this is not currently used, just wanted to
make sure you were aware that I'm deleting it.

[Harry Terkelsen, 2016-08-12 17:22:38]

lgtm

[Bill Hesse, 2016-08-12 18:48:09]

whesse@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2016-08-12 18:48:10]

Don't do it yet - wait for Peter.

The try tests were just temporarily removed, because the bots that were running
it stopped building the SDK themselves.  I intended to start running the tests
again on new bots.

These are the only ways we have of testing incremental recompilation in dart2js,
I think.  This was being used by dartino, but nobody else.  It also would have
been better to make some direct tests of this feature, since the try site and
tests are extremely heavy.

I know the VM incremental reload feature is used by flutter, but that should
have nothing to do with this.  I think this is only the dart2js incremental
compilation.

We should only stop testing dart2js incremental compilation if we are planning
to remove the feature completely.  Otherwise, we should keep try until we have
other tests of it.

Please loop in any other people who might know about the issue, and make sure
all stakeholders agree on a plan.

[Siggi Cherem (dart-lang), 2016-08-12 19:05:16]

Peter and I actually talked about this yesterday, so I think we are good :-)

We agreed on a plan to help us gain some velocity in a big refactoring we are
doing in dart2js. Dartino continues to have coverage for this feature, so we
should be good there too. There are a few APIs that need to remain in the
dart2js codebase that Peter needs, but we should be able to set up small tests
for those as needed. Peter could you help us set those up? that would be
fantastic!

I'm happy to chat more to clarify in more detail.

[Bill Hesse, 2016-08-12 19:15:05]

On 2016/08/12 19:05:16, Siggi Cherem (dart-lang) wrote:
> Peter and I actually talked about this yesterday, so I think we are good :-)
> 
> We agreed on a plan to help us gain some velocity in a big refactoring we are
> doing in dart2js. Dartino continues to have coverage for this feature, so we
> should be good there too. There are a few APIs that need to remain in the
> dart2js codebase that Peter needs, but we should be able to set up small tests
> for those as needed. Peter could you help us set those up? that would be
> fantastic!
> 
> I'm happy to chat more to clarify in more detail.

LGTM then, push the button.

[Siggi Cherem (dart-lang), 2016-08-15 19:14:49]

Description was changed from

==========
Delete site/try
==========

to

==========
Delete site/try

R=het@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2ee3b9fae66ecd29a5898a803319cf2e384ea95d
==========

[Siggi Cherem (dart-lang), 2016-08-15 19:14:51]

Committed patchset #1 (id:1) manually as
2ee3b9fae66ecd29a5898a803319cf2e384ea95d (presubmit successful).